You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2024/07/11 04:31:12 UTC

(spark) branch master updated: [SPARK-48280][SQL][FOLLOWUP] Improve collation testing surface area using expression walking

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 225b6cbf1297 [SPARK-48280][SQL][FOLLOWUP] Improve collation testing surface area using expression walking
225b6cbf1297 is described below

commit 225b6cbf129761705d882b5b68c82ac0d7325e92
Author: Uros Bojanic <15...@users.noreply.github.com>
AuthorDate: Thu Jul 11 13:30:59 2024 +0900

    [SPARK-48280][SQL][FOLLOWUP] Improve collation testing surface area using expression walking
    
    ### What changes were proposed in this pull request?
    Followup: small correction.
    
    ### Why are the changes needed?
    UTF8_BINARY_LCASE no longer exists in Spark.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Existing tests.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #47216 from uros-db/fix-walker.
    
    Authored-by: Uros Bojanic <15...@users.noreply.github.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 .../scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala
index d582167478da..a639367e8ca5 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/CollationExpressionWalkerSuite.scala
@@ -604,7 +604,7 @@ class CollationExpressionWalkerSuite extends SparkFunSuite with SharedSparkSessi
       "unix_timestamp",
       "localtimestamp",
       "now",
-      // need to skip as plans differ in STRING <-> STRING COLLATE UTF8_BINARY_LCASE
+      // need to skip as plans differ in STRING <-> STRING COLLATE UTF8_LCASE
       "current_timezone",
       "schema_of_variant",
       // need to skip as result is expected to differ


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org