[jira] Commented: (XERCESC-398) DOMString::appendData(const DOMString&) is broken

[xe...@xml.apache.org]

The following comment has been added to this issue:

     Author: PeiYong Zhang
    Created: Tue, 19 Oct 2004 9:58 AM
       Body:
Vladimir,

      As the community becomes more and more concerned about the 
      license and copyright issues related to code contribution, 
      we would be more than happy to check in the patch submitted 
      once you have kindly completed the followings:
 
   .Who is your employer?
		 
   .Did you write the code that you wish to contribute to Apache? 
    If not, please identify the complete details of the code's source 
    and of any licenses or restrictions applicable to the code.

   .Do you have the right to grant the copyright and patent licenses 
    for the contribution that are set forth in the ASF v.2.0 license 
    (http://www.apache.org/licenses/LICENSE-2.0)
    
   .Does your employer have any rights to the code that you have 
    written, for example, through your contract for employment?  
    If so, has your employer given you permission to contribute the 
    code on its behalf or waived its rights in the code?
	 
   .Are you aware of any third-party licenses or other restrictions 
   (such as related patents or trademarks), that could apply to your 
    contribution? If so, what are they?

    Thanks.

Rgds
PeiYong
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/XERCESC-398?page=comments#action_54350

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/XERCESC-398

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XERCESC-398
    Summary: DOMString::appendData(const DOMString&) is broken
       Type: Bug

     Status: Open

    Project: Xerces-C++
 Components: 
             DOM
   Versions:
             1.6.0

   Assignee: Xerces-C Developers Mailing List
   Reporter: Vladimir Dozen

    Created: Wed, 27 Mar 2002 12:34 PM
    Updated: Tue, 19 Oct 2004 9:58 AM
Environment: Operating System: Other
Platform: All

Description:
DOMString::appendData does not add trailing zero to resulting string, which
causes trash characters be written into attribute values (for example).

Part of method code:
====================================
    //
    // This string now had enough buffer room to hold the data to
    //  be appended.  Go ahead and copy it in.
    XMLCh *srcP = other.fHandle->fDSData->fData;
    XMLCh *destP = &fHandle->fDSData->fData[fHandle->fLength];
    unsigned int i;
    for (i=0; i<other.fHandle->fLength; i++)
        destP[i] = srcP[i];
 
    // dozen: here is my fix for this bug
    destP[i] = 0;

    fHandle->fLength += other.fHandle->fLength;
}
======================================


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org