[GitHub] [arrow] kiszk edited a comment on pull request #7277: ARROW-8957: [FlightRPC][C++] directly use IpcWriteOptions

[GitBox <gi...@apache.org>]

kiszk edited a comment on pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#issuecomment-634737470


   Thanks, we still have build failure in another place at https://travis-ci.org/github/apache/arrow/jobs/691713153#L1015
   
   @lidavidm can we remove `std::move()` as a compiler suggested? In https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/server.cc#L118, `std::move()` is not called.
   
   ```
   /arrow/cpp/src/arrow/flight/client.cc:391:50:   required from here
   /arrow/cpp/src/arrow/flight/client.cc:411:28: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
     411 |     return std::move(result);
         |                            ^
   /arrow/cpp/src/arrow/flight/client.cc:411:28: note: remove 'std::move' call
   /arrow/cpp/src/arrow/flight/client.cc: In instantiation of 'arrow::Result<std::unique_ptr<arrow::ipc::Message> > arrow::flight::GrpcIpcMessageReader<Reader>::ReadNextMessage() [with Reader = grpc_impl::ClientReaderWriter<arrow::flight::protocol::FlightData, arrow::flight::protocol::FlightData>]':
   /arrow/cpp/src/arrow/flight/client.cc:391:50:   required from here
   /arrow/cpp/src/arrow/flight/client.cc:411:28: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
   /arrow/cpp/src/arrow/flight/client.cc:411:28: note: remove 'std::move' call
   cc1plus: all warnings being treated as errors
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org