You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org> on 2012/01/05 16:31:39 UTC
[jira] [Commented] (QPID-3688) AMQDestination and children should
conform to the JavaBean pattern
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180465#comment-13180465 ]
Robbie Gemmell commented on QPID-3688:
--------------------------------------
I agree that the destinations should be immutable, and given what they store they really should be just getting created based on Strings (as e.g the session.createQueue() or JNDI properties file methods would)
I take it the intention is that the protected default constructors would only be used by subclassing the various destination objects?
The new AMQDestination constructor added seems like it should possibly use the 'default syntax' value located in the class rather than just assuming it is ADDR, and the 'setAddressString' method could then set _destSyntax if it is ever used or throw an exception if the two conflicted.
I'm possibly missing something, but if the calling code can be altered such that it is able to use the 'setAddressString' method, whats stopping it being made to use the existing String constructors for the objects?
> AMQDestination and children should conform to the JavaBean pattern
> ------------------------------------------------------------------
>
> Key: QPID-3688
> URL: https://issues.apache.org/jira/browse/QPID-3688
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: 0.12
> Environment: All platforms.
> Reporter: Weston M. Price
> Assignee: Rajith Attapattu
> Fix For: Future
>
> Attachments: QPID-3688.patch
>
>
> In order to support deploying and managing AMQDestination's in JEE application servers, conformance to the JavaBean design pattern is preferred as many appellation servers have their own management infrastructure for supporting Administrative objects that require, at the very least, a default constructor to create and bootstrap the destination into the server address space.
> The AMQDestination and children classes should support this to make JEE integration easier and more consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org