You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/13 18:53:09 UTC
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6629
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
[mini-kdc] adapted config for krb5 1.15
Starting with version 1.15 of Kerberos5, the krb5adm by default listens
on TCP ports as well if not specified otherwise. However, the mini-kdc
logic assumes the daemon listens only on UDP ports. Explicit setting of
the kdc_tcp_ports configuration property to an empty string in krb.conf
disables opening TCP ports.
Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6629/1
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
Patch Set 2:
Unrelated error due to change in error message -- will address that separately.
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
Patch Set 1:
> Do we need this in the Java kdc also?
Ugh, sure. I haven't run Java tests since upgrading my MacPorts.
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
[mini-kdc] adapted config for krb5 1.15
Starting with version 1.15 of Kerberos5, the krb5kdc by default listens
on TCP ports as well if not specified otherwise. However, the mini-kdc
logic assumes the daemon listens only on UDP ports. Explicit setting of
the kdc_tcp_ports configuration property to an empty string in krb.conf
disables opening of the TCP ports by krb5kdc.
Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Reviewed-on: http://gerrit.cloudera.org:8080/6629
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
M src/kudu/security/test/mini_kdc.cc
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
Patch Set 1:
Do we need this in the Java kdc also?
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-kdc] adapted config for krb5 1.15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6629
to look at the new patch set (#2).
Change subject: [mini-kdc] adapted config for krb5 1.15
......................................................................
[mini-kdc] adapted config for krb5 1.15
Starting with version 1.15 of Kerberos5, the krb5kdc by default listens
on TCP ports as well if not specified otherwise. However, the mini-kdc
logic assumes the daemon listens only on UDP ports. Explicit setting of
the kdc_tcp_ports configuration property to an empty string in krb.conf
disables opening of the TCP ports by krb5kdc.
Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
M src/kudu/security/test/mini_kdc.cc
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6629/2
--
To view, visit http://gerrit.cloudera.org:8080/6629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie793b742c2d41f935178f3f4da7a0d0923f79816
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>