[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2171: Adjust the read and write timeout configuration of the http server

[GitBox <gi...@apache.org>]

bzp2010 commented on a change in pull request #2171:
URL: https://github.com/apache/apisix-dashboard/pull/2171#discussion_r731586563



##########
File path: api/internal/core/server/http.go
##########
@@ -50,8 +50,8 @@ func (s *server) setupAPI() {
 	s.server = &http.Server{
 		Addr:         addr,
 		Handler:      r,
-		ReadTimeout:  time.Duration(1000) * time.Millisecond,
-		WriteTimeout: time.Duration(5000) * time.Millisecond,
+		ReadTimeout:  time.Duration(5000) * time.Millisecond,
+		WriteTimeout: time.Duration(60000) * time.Millisecond,

Review comment:
       I think it should be changed to add `gzip` middleware. It will greatly reduce the volume of transferred files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org