[GitHub] [arrow-rs] viirya commented on a diff in pull request #1621: Fix decimals min max statistics

[GitBox <gi...@apache.org>]

viirya commented on code in PR #1621:
URL: https://github.com/apache/arrow-rs/pull/1621#discussion_r858834884


##########
parquet/src/column/writer.rs:
##########
@@ -1006,6 +1057,42 @@ impl<T: DataType> ColumnWriterImpl<T> {
                 return a.as_u64().unwrap() > b.as_u64().unwrap();
             }
         }
+
+        match self.descr.converted_type() {
+            ConvertedType::UINT_8
+            | ConvertedType::UINT_16
+            | ConvertedType::UINT_32
+            | ConvertedType::UINT_64 => {
+                return a.as_u64().unwrap() > b.as_u64().unwrap();
+            }
+            _ => {}
+        };
+
+        if let Some(LogicalType::DECIMAL(_)) = self.descr.logical_type() {

Review Comment:
   A few compilation errors:
   
   ```
   error[E0599]: no variant or associated item named `DECIMAL` found for enum `basic::LogicalType` in the current scope
       --> parquet/src/column/writer.rs:1071:34
        |
   1071 |         if let Some(LogicalType::DECIMAL(_)) = self.descr.logical_type() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org