svn commit: r1088415 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java

[hl...@apache.org]

Author: hlship
Date: Sun Apr  3 20:56:31 2011
New Revision: 1088415

URL: http://svn.apache.org/viewvc?rev=1088415&view=rev
Log:
TAP5-98: Remove unneeded contributions to TypeCoercer for String to Enum coercions

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1088415&r1=1088414&r2=1088415&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Sun Apr  3 20:56:31 2011
@@ -75,11 +75,6 @@ import org.apache.tapestry5.annotations.
 import org.apache.tapestry5.annotations.Service;
 import org.apache.tapestry5.beaneditor.Validate;
 import org.apache.tapestry5.corelib.ClientValidation;
-import org.apache.tapestry5.corelib.LoopFormState;
-import org.apache.tapestry5.corelib.SubmitMode;
-import org.apache.tapestry5.corelib.data.BlankOption;
-import org.apache.tapestry5.corelib.data.GridPagerPosition;
-import org.apache.tapestry5.corelib.data.InsertPosition;
 import org.apache.tapestry5.grid.GridDataSource;
 import org.apache.tapestry5.internal.AssetConstants;
 import org.apache.tapestry5.internal.DefaultNullFieldStrategy;
@@ -1102,22 +1097,17 @@ public final class TapestryModule
      * Adds coercions:
      * <ul>
      * <li>String to {@link SelectModel}
-     * <li>String to {@link InsertPosition}
      * <li>Map to {@link oSelectModel}
      * <li>Collection to {@link GridDataSource}
      * <li>null to {@link GridDataSource}
-     * <li>String to {@link GridPagerPosition}
      * <li>List to {@link SelectModel}
      * <li>{@link .ComponentResourcesAware} (typically, a component) to {@link ComponentResources}
-     * <li>String to {@link BlankOption}
      * <li> {@link ComponentResources} to {@link PropertyOverrides}
      * <li>String to {@link Renderable}
      * <li>{@link Renderable} to {@link Block}
      * <li>String to {@link DateFormat}
      * <li>String to {@link Resource} (via {@link AssetSource#resourceForPath(String)})
      * <li>{@link Renderable} to {@link RenderCommand}</li>
-     * <li>String to {@link LoopFormState}</li>
-     * <li>String to {@link SubmitMode}</li>
      * <li>String to {@link Pattern}</li>
      * <li>String to {@link DateFormat}</li>
      * </ul>
@@ -1178,12 +1168,6 @@ public final class TapestryModule
             }
         }));
 
-        add(configuration, GridPagerPosition.class);
-        add(configuration, InsertPosition.class);
-        add(configuration, BlankOption.class);
-        add(configuration, LoopFormState.class);
-        add(configuration, SubmitMode.class);
-
         configuration.add(CoercionTuple.create(List.class, SelectModel.class, new Coercion<List, SelectModel>()
         {
             @SuppressWarnings("unchecked")
@@ -1278,12 +1262,6 @@ public final class TapestryModule
         configuration.add(CoercionTuple.create(String.class, ClientValidation.class, stringToClientValidationCoercion));
     }
 
-    @SuppressWarnings("rawtypes")
-    private static <T extends Enum> void add(Configuration<CoercionTuple> configuration, Class<T> enumType)
-    {
-        configuration.add(CoercionTuple.create(String.class, enumType, StringToEnumCoercion.create(enumType)));
-    }
-
     /**
      * Adds built-in constraint generators:
      * <ul>