[jira] [Commented] (DRILL-7294) Prevent generating java beans using protostuff to avoid overriding classes with the same simple name declared as nested in the proto files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863179#comment-16863179 ] 

ASF GitHub Bot commented on DRILL-7294:
---------------------------------------

vvysotskyi commented on pull request #1808: DRILL-7294: Prevent generating java beans using protostuff to avoid overriding classes with the same simple name declared as nested in the proto files
URL: https://github.com/apache/drill/pull/1808
 
 
   This PR contains two commits:
   - the first commit contains changes produced manually:
   -- removed generating beans using protostuff;
   -- updated protostuff version;
   -- replaced usage of beans generated with protostuff
   - the second commit contains changes caused by regenerating protobufs.
   
   For problem description, please see [DRILL-7294](https://issues.apache.org/jira/browse/DRILL-7294).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prevent generating java beans using protostuff to avoid overriding classes with the same simple name declared as nested in the proto files
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-7294
>                 URL: https://issues.apache.org/jira/browse/DRILL-7294
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.17.0
>
>
> Currently, {{protostuff-maven-plugin}} generates java-bean classes from proto files. But these classes already generated by protobuf, the single difference is that they are placed in a different package, and preserved the nesting of the classes as they are declared in the proto files.
> protostuff creates new files for nested classes, and it causes problems for the case when several nested classes have the same name - they override each other, for example here is Travis failure caused by this problem: https://travis-ci.org/apache/drill/jobs/545013395



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)