You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2023/01/28 16:37:20 UTC
[pulsar] branch master updated: [improve][broker] Added isActive in ManagedCursorImpl (#19341)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 96fb7dab7a1 [improve][broker] Added isActive in ManagedCursorImpl (#19341)
96fb7dab7a1 is described below
commit 96fb7dab7a1bc260d8ee3c9d5df15de6863ee15b
Author: Heesung Sohn <10...@users.noreply.github.com>
AuthorDate: Sat Jan 28 08:37:13 2023 -0800
[improve][broker] Added isActive in ManagedCursorImpl (#19341)
---
.../apache/bookkeeper/mledger/impl/ManagedCursorImpl.java | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index 5b351c99649..34cd26274ff 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -218,6 +218,9 @@ public class ManagedCursorImpl implements ManagedCursor {
private static final String COMPACTION_CURSOR_NAME = "__compaction";
private volatile boolean cacheReadEntry = false;
+ // active state cache in ManagedCursor. It should be in sync with the state in activeCursors in ManagedLedger.
+ private volatile boolean isActive = false;
+
class MarkDeleteEntry {
final PositionImpl newPosition;
final MarkDeleteCallback callback;
@@ -1208,19 +1211,23 @@ public class ManagedCursorImpl implements ManagedCursor {
@Override
public void setActive() {
- if (!alwaysInactive) {
+ if (!isActive && !alwaysInactive) {
ledger.activateCursor(this);
+ isActive = true;
}
}
@Override
public boolean isActive() {
- return ledger.isCursorActive(this);
+ return isActive;
}
@Override
public void setInactive() {
- ledger.deactivateCursor(this);
+ if (isActive) {
+ ledger.deactivateCursor(this);
+ isActive = false;
+ }
}
@Override