[GitHub] [iceberg] xiaoxuandev commented on pull request #8221: AWS: Add retry logic for S3InputStream and S3OutputStream

["xiaoxuandev (via GitHub)" <gi...@apache.org>]

xiaoxuandev commented on PR #8221:
URL: https://github.com/apache/iceberg/pull/8221#issuecomment-1666962729

   Thanks. @nastra I see what you are proposing but in our case the SDK level retry wouldn't help. Because we are using this method 
   https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Client.html#getObject(software.amazon.awssdk.services.s3.model.GetObjectRequest,software.amazon.awssdk.core.sync.ResponseTransformer) which returns us a stream we will read from. The SDK level retry doesn't give us coverage beyond this call. In our case, the exceptions are thrown post this call when we are reading from the stream. That is why we need to add retries here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org