You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/07/18 00:05:34 UTC
Review Request 67953: Disabled the clang
`-Winconsistent-missing-override` warning.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67953/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Benjamin Mahler.
Repository: mesos
Description
-------
Clang can emit a `-Winconsistent-missing-override` warning for most
uses of the Google Mock `MOCK_METHOD` family of macros. See also
https://github.com/google/googletest/issues/533.
Diffs
-----
cmake/CompilationConfigure.cmake 49b2dc0deec939e4c61b39c91bc5be4765fee194
configure.ac 5f64168ce8867b23f0aed20f30682ebd35711ceb
Diff: https://reviews.apache.org/r/67953/diff/1/
Testing
-------
make (Fedora 28)
Thanks,
James Peach
Re: Review Request 67953: Disabled the clang
`-Winconsistent-missing-override` warning.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67953/#review206184
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 17, 2018, 5:05 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67953/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 5:05 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clang can emit a `-Winconsistent-missing-override` warning for most
> uses of the Google Mock `MOCK_METHOD` family of macros. See also
> https://github.com/google/googletest/issues/533.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 49b2dc0deec939e4c61b39c91bc5be4765fee194
> configure.ac 5f64168ce8867b23f0aed20f30682ebd35711ceb
>
>
> Diff: https://reviews.apache.org/r/67953/diff/1/
>
>
> Testing
> -------
>
> make (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67953: Disabled the clang
`-Winconsistent-missing-override` warning.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67953/#review206189
-----------------------------------------------------------
PASS: Mesos patch 67953 was successfully built and tested.
Reviews applied: `['67953']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1948/mesos-review-67953
- Mesos Reviewbot Windows
On July 18, 2018, 12:05 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67953/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 12:05 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clang can emit a `-Winconsistent-missing-override` warning for most
> uses of the Google Mock `MOCK_METHOD` family of macros. See also
> https://github.com/google/googletest/issues/533.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 49b2dc0deec939e4c61b39c91bc5be4765fee194
> configure.ac 5f64168ce8867b23f0aed20f30682ebd35711ceb
>
>
> Diff: https://reviews.apache.org/r/67953/diff/1/
>
>
> Testing
> -------
>
> make (Fedora 28)
> cmake (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>