You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by "Kevan Jahanshahi (Jira)" <ji...@apache.org> on 2022/06/09 18:08:00 UTC

[jira] [Commented] (UNOMI-569) Refactor schemas to respect flat props and no nested

    [ https://issues.apache.org/jira/browse/UNOMI-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552365#comment-17552365 ] 

Kevan Jahanshahi commented on UNOMI-569:
----------------------------------------

JSON Schemas of Unomi have been cleaned in the same PR.

Our first strategy was wrong, we created a lot of schemas for everything, ending with stuff we dont understand and not being able to fix them or even understand what to do.So … I remove a lot of schemas only keeping the essentials (the current scope we know and we understand)

Globally speaking I prefer to remove all schemas that are unclear or unknown to us, so that the scope is better controlled and we are able to understand what we do.Here I propose the following strategy for upcoming missing/incomplete schemas is: * You see something missing ?
 * Raise the hand
 * We discuss (where should the schema belong Unomi client ? Unomi ?)
 * We plan (create task)
 * We add the schemas and the tests


Unomi schemas should be a lot more readable and understandable and this will definietely help to achieve next steps even if all questions are not yet answered like: * Should view event be in client ? or Should form event be in Unomi ?
 ** Actually to make it work we dont really care, what is important as a first step is to have good schemas, we could still discuss at the end where we want to put them.

 * Should we create schemas for web-tracker events ? like articleCompleted, identify events ?
 ** We dont really care right now, and discussions are already planned around web-tracker topic so we will decide and follow the strategy up there, but for now I removed them (like mentioned previously I prefer to not have incomplete schemas on stuff we dont understand, we will add them later after discussion and task will be created for them)


Let’s focus on the goals: * make Unomi client and the events we know working with new data structure and Schemas
 * protect the products against mapping explosion
 * discuss and plan in case there is uncertainties on the road

> Refactor schemas to respect flat props and no nested
> ----------------------------------------------------
>
>                 Key: UNOMI-569
>                 URL: https://issues.apache.org/jira/browse/UNOMI-569
>             Project: Apache Unomi
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 2.0.0
>            Reporter: David Griffon
>            Assignee: Kevan Jahanshahi
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> As we want to use [unevaluated properties|https://json-schema.org/understanding-json-schema/reference/object.html#id7] that does not propagate sub objects we need to flatten schema to not contain sub objects (one object per schema)
> Clean up unused schemas



--
This message was sent by Atlassian Jira
(v8.20.7#820007)