You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "junrushao (via GitHub)" <gi...@apache.org> on 2023/05/09 19:54:26 UTC

[GitHub] [tvm] junrushao commented on a diff in pull request #14812: [TVMScript] Handle AllocatedPoolInfo, ConstantPoolInfo, ConstantInfo

junrushao commented on code in PR #14812:
URL: https://github.com/apache/tvm/pull/14812#discussion_r1189071460


##########
python/tvm/ir/memory_pools.py:
##########
@@ -245,7 +245,7 @@ def __init__(
         )
 
 
-@register_object("ir.ConstantMemoryPools")

Review Comment:
   A bit off the topic, but to some extent, I believe it might be less ideal if we expose those feature-dependent component in `tvm/ir` folder, which is supposed to be generic. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org