You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Branislav Cogic <b....@levi9.com> on 2016/06/13 09:16:28 UTC

Review Request 48621: SAMZA-949: KafkaCheckpointManager should not try forever for non-recoverable checkpoint deserialization failures

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48621/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-949
    https://issues.apache.org/jira/browse/SAMZA-949


Repository: samza


Description
-------

Added limit to number of retries in ExponentialSleepStrategy. KafkaCheckpointManager is not trying forever when exception occurs. Container fails when DifferentSystemStreamGrouperFactoryValue and new CheckpointDeserializationException excpetion occurs


Diffs
-----

  samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 4a04c130d33aae1e1dfbac1ae58155dafbc23b35 
  samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala 9ba8a4deb3a98b81362bf5fafab45a3657b7ae23 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointLogKey.scala ea8462dc10d0c98fe99215e6b6b9d59cce4bcffa 
  samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 
  samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 

Diff: https://reviews.apache.org/r/48621/diff/


Testing
-------

./gradlew clean build and manual testing


Thanks,

Branislav Cogic