[GitHub] [superset] codyml commented on a diff in pull request #20728: feat(dashboard): Add Drill to Detail modal w/ chart menu access

[GitBox <gi...@apache.org>]

codyml commented on code in PR #20728:
URL: https://github.com/apache/superset/pull/20728#discussion_r942916256


##########
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/EchartsGauge.tsx:
##########
@@ -77,7 +77,7 @@ export default function EchartsGauge({
         const pointerEvent = e.event.event;
         const filters: QueryObjectFilterClause[] = [];
         if (groupby.length > 0) {
-          const values = e.name.split(',');

Review Comment:
   @michael-s-molina This was breaking for single values that had commas in them - does my replacement make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org