You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ottobackwards <gi...@git.apache.org> on 2017/03/20 18:04:15 UTC
[GitHub] nifi-maven pull request #2: NIFI-3628 allow override additions for extention...
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi-maven/pull/2
NIFI-3628 allow override additions for extention and id prefixes
This PR introduces the ability to change the extension name though changing the type property as well as specifying the prefix on the Nar-XXXX manifest entries.
The type property is used to specify the file extension, and hardcoded instances of 'nar' are changed to use this property consistantly.
The property is also used in the NarDependencyMojo, such that the hardcoded NAR='nar' usage is changed to use the type property. The configuration of this property will govern both mojos.
The defaults are all left as [N,n]ar. Such that there are NO required changes to existing POMs or archetypes to continue working after this change.
This was tested by building building the archetype, and building nifi with the pom reference changed to the version built ( validating from the logs the plugin version used ).
All tests run and pass
Nifi was run from the assembly dir, and a flow created, logs viewed to verify that there were no errors loading / unpacking the nars, running the flows.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi-maven NIFI-3628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-maven/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit f876fb78d90a3a93363c4d9473ad4315eca0b58a
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-03-20T14:00:35Z
override additions for extention and id prefixes
override prefix for Nar-* manifest properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-maven pull request #2: NIFI-3628 allow override additions for extention...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi-maven/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---