You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/08/19 16:30:31 UTC

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version 

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17795


Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................

IMPALA-10874: Upgrade impyla to the latest version

This patch upgrades impyla to the latest version 0.18a1, which supports
cookie retention for LDAP authentications. Also adds unit-test cases
for implyla's HTTP test with LDAP authentication.

Testing:
 - Passed core tests.

Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M infra/python/deps/requirements.txt
M tests/util/run_impyla_http_query.py
3 files changed, 112 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17795/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 2:

I've added Joe McDonnell as a reviewer to approve the change.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 18:43:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 05:52:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7417/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 23:32:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 2: Code-Review+2

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 23:24:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17795/1/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/17795/1/infra/python/deps/requirements.txt@40
PS1, Line 40:   sasl == 0.3.1
I think impyla doesn't rely on sasl package anymore. Could you please check it?



-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 19:24:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................

IMPALA-10874: Upgrade impyla to the latest version

This patch upgrades impyla to the latest version 0.18a1, which supports
cookie retention for LDAP authentications. Also adds unit-test cases
for implyla's HTTP test with LDAP authentication.

Testing:
 - Passed core tests.

Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Reviewed-on: http://gerrit.cloudera.org:8080/17795
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M infra/python/deps/requirements.txt
M tests/util/run_impyla_http_query.py
3 files changed, 112 insertions(+), 13 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

impala-shell has its own copy of bitarray and sasl libs with source code under shell/ext-py. It still uses bitarray-1.2.1 and sasl-0.2.1. To upgrade libraries for impala-shell, we need to replace the source code of the libraries.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 Aug 2021 23:36:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 18:40:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 23:32:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

@Bikramjeet If I remember correctly, impyla doesn't rely on 'sasl' anymore, so that dependency can be removed from requirements.txt. I think it is safe to upgrade 'bitarray'.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 19:27:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................

IMPALA-10874: Upgrade impyla to the latest version

This patch upgrades impyla to the latest version 0.18a1, which supports
cookie retention for LDAP authentications. Also adds unit-test cases
for implyla's HTTP test with LDAP authentication.

Testing:
 - Passed core tests.

Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java
M infra/python/deps/requirements.txt
M tests/util/run_impyla_http_query.py
3 files changed, 112 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/17795/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 16:52:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 00:11:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1: Code-Review+1

Looks good to me. @Attila will the version changes in requirements.txt for dependent libs like sasl or bitarray affect other dependencies?


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 23:05:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17795/1/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/17795/1/infra/python/deps/requirements.txt@40
PS1, Line 40:   sasl == 0.3.1
> I think impyla doesn't rely on sasl package anymore. Could you please check
Right, we remove reference to sasl in 0.17a5. Will remove it as third party library here.



-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 20:42:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 )

Change subject: IMPALA-10874: Upgrade impyla to the latest version
......................................................................


Patch Set 1:

Tried to remove "sasl" from requirements.txt. But it caused impala-shell and tests/util/thrift_util.py failed since shell/impala_client.py and tests/util/thrift_util.py import "sasl". We still need to leave "sasl" in requirements.txt, but not under impyla. 
Another issue is impala-shell does not use "sasl" in shell/ext-py. shell/ext-py is not in Python library path.


-- 
To view, visit http://gerrit.cloudera.org:8080/17795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990e5cdde4e98d6ab3581fe48f53a5d0590ce492
Gerrit-Change-Number: 17795
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 22:12:24 +0000
Gerrit-HasComments: No