You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/18 21:35:58 UTC

[GitHub] [thrift] cfriedt commented on pull request #2007: THRIFT-5093: TMemoryBuffer fix wpos for policy == OBSERVER

cfriedt commented on PR #2007:
URL: https://github.com/apache/thrift/pull/2007#issuecomment-1101787757

   @emmenlau - repurposing this ticket to simply add clarifying tests.
   
   My main use case with the original code change was that I wanted to be able to call `resetBuffer()` on `OBSERVE` buffers and reuse them for test cases. I can achieve that by calling `resetBuffer(ro_mem, ro_mem_size, OBSERVE)` as well, so the workaround is fairly trivial. It makes more sense to have consistent behaviour for all `resetBuffer()` implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org