You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/13 18:09:37 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10303: refactor: database API OpenAPI spec and location
dpgaspar opened a new pull request #10303:
URL: https://github.com/apache/incubator-superset/pull/10303
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10303: refactor: database API OpenAPI spec and location
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10303:
URL: https://github.com/apache/incubator-superset/pull/10303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #10303: refactor: database API OpenAPI spec and location
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #10303:
URL: https://github.com/apache/incubator-superset/pull/10303#discussion_r455181608
##########
File path: superset/databases/api.py
##########
@@ -311,15 +239,11 @@ def select_star(
description: Table schema
responses:
200:
- description: select star for table
+ description: Query result
Review comment:
Does this actually return a query result? I thought it returned a SQL string representing the verbose equivalent of `SELECT * FOR <table_name>` for the referenced table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed pull request #10303: refactor: database API OpenAPI spec and location
Posted by GitBox <gi...@apache.org>.
dpgaspar closed pull request #10303:
URL: https://github.com/apache/incubator-superset/pull/10303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10303: refactor: database API OpenAPI spec and location
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10303:
URL: https://github.com/apache/incubator-superset/pull/10303#discussion_r455187077
##########
File path: superset/databases/api.py
##########
@@ -311,15 +239,11 @@ def select_star(
description: Table schema
responses:
200:
- description: select star for table
+ description: Query result
Review comment:
Totally right, nice catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org