You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/14 02:15:01 UTC

[GitHub] [hbase] infraio commented on pull request #2772: HBASE-25387 TagRewriteCell's getSerializedSize() method gets the size…

infraio commented on pull request #2772:
URL: https://github.com/apache/hbase/pull/2772#issuecomment-744123579


   > > This needs a thorough check. When we write to Hfile stream, if the top level says write tags as true, we have to write the tags length even if it is 0. In a stream we might write cells which is having tags and some not having any tags. While reading back we rely on this tags length short value to know whether tags are there or not for this particular cell. So on high level this additional check is wrong. Did u observer any issue functionally?
   > 
   > But all subclasses of the higher level class ExtendedCell will not write tag length even when tag length is 0, except TagRweriteCell.
   
   So only TagRewriteCell forgot the check of tags.length? Can yuu paste some code to show this. Thanks.
   
   And the HBase QA failed. Please take a look about this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org