You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jim Brennan (Jira)" <ji...@apache.org> on 2020/07/13 22:02:00 UTC
[jira] [Updated] (HADOOP-17127) Use RpcMetrics.TIMEUNIT to
initialize rpc queueTime and processingTime
[ https://issues.apache.org/jira/browse/HADOOP-17127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Brennan updated HADOOP-17127:
---------------------------------
Attachment: HADOOP-17127.001.patch
> Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and processingTime
> ----------------------------------------------------------------------
>
> Key: HADOOP-17127
> URL: https://issues.apache.org/jira/browse/HADOOP-17127
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HADOOP-17127.001.patch
>
>
> While making an internal change to use {{TimeUnit.MICROSECONDS}} instead of {{TimeUnit.MILLISECONDS}} for rpc details, we found that we also had to modify this code in DecayRpcScheduler.addResponseTime() to initialize {{queueTime}} and {{processingTime}} with the correct units.
> {noformat}
> long queueTime = details.get(Timing.QUEUE, TimeUnit.MILLISECONDS);
> long processingTime = details.get(Timing.PROCESSING, TimeUnit.MILLISECONDS);
> {noformat}
> If we change these to use {{RpcMetrics.TIMEUNIT}} it is simpler.
> We also found one test case in TestRPC that was assuming the units were milliseconds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org