[GitHub] [flink] KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate
URL: https://github.com/apache/flink/pull/8176#discussion_r276071545
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/FlinkRelOptUtil.scala
 ##########
 @@ -104,10 +105,19 @@ object FlinkRelOptUtil {
     *
     * @return Whether any of the aggregates are accurate DISTINCT
     */
-  def containsAccurateDistinctCall(aggCalls: Seq[AggregateCall]): Boolean = {
+  def containsAccurateDistinctCall(aggCalls: util.List[AggregateCall]): Boolean = {
     aggCalls.exists(call => call.isDistinct && !call.isApproximate)
   }
 
+  /**
+    * Returns whether any of the aggregates are approximate DISTINCT.
+    *
+    * @return Whether any of the aggregates are approximate DISTINCT
+    */
+  def containsApproximateDistinctCall(aggCalls: util.List[AggregateCall]): Boolean = {
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services