You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/26 15:37:26 UTC
[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Donny9 opened a new pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865
## Summary
fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
reference:
https://en.wikipedia.org/wiki/GUID_Partition_Table
https://en.wikipedia.org/wiki/Master_boot_record
example:
create mbr partition:
mkmbr /dev/mmcsd0 2 1024 1028 1024 2050 auto
create gpt partition:
mkgpt write /dev/mmcsd0 p1:10G p2:2G p3:1G p4:4G p5:8G p6:1G p7:1G
read gpt partition:
mkgpt read /dev/mmcsd0
## Impact
support format mbr and gpt partition.
## Testing
local test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on a change in pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865#discussion_r737091549
##########
File path: fsutils/mkgpt/Kconfig
##########
@@ -0,0 +1,12 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config FSUTILS_MKGPT
+ bool "mkgpt utility"
+ default n
+ select BCH
+ select DEV_URANDOM
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865#discussion_r736872658
##########
File path: fsutils/mkgpt/Makefile
##########
@@ -0,0 +1,32 @@
+############################################################################
+# apps/fsutils/mkgpt/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# mkmbr built-in application info
Review comment:
```suggestion
# mkgpt built-in application info
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on a change in pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865#discussion_r737091828
##########
File path: fsutils/mkgpt/Makefile
##########
@@ -0,0 +1,32 @@
+############################################################################
+# apps/fsutils/mkgpt/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# mkmbr built-in application info
Review comment:
done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #865: fsutils: support mkmbr and mkgpt to format mbr and gpt pratition
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #865:
URL: https://github.com/apache/incubator-nuttx-apps/pull/865#discussion_r736872117
##########
File path: fsutils/mkgpt/Kconfig
##########
@@ -0,0 +1,12 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config FSUTILS_MKGPT
+ bool "mkgpt utility"
+ default n
+ select BCH
+ select DEV_URANDOM
Review comment:
```suggestion
select DEV_URANDOM
```
Change whitespaces to tabs for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org