You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 18:21:36 UTC
[GitHub] [arrow] ViniciusSouzaRoque opened a new pull request, #13682: ARROW-17171: [C++][Gandiva] Implement case-insensitive
ViniciusSouzaRoque opened a new pull request, #13682:
URL: https://github.com/apache/arrow/pull/13682
Implementing changes for the function to be case-insensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a diff in pull request #13682: ARROW-17171: [C++][Gandiva] Implement NextDay Function to case-insensitive
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on code in PR #13682:
URL: https://github.com/apache/arrow/pull/13682#discussion_r933313824
##########
cpp/src/gandiva/precompiled/time.cc:
##########
@@ -261,8 +261,22 @@ static const int WEEK_LEN[] = {6, 6, 7, 9, 8, 6, 8};
const auto& presentDate = extractDow_timestamp(tp.MillisSinceEpoch()); \
\
int dateSearch = 0; \
+ \
+ /* To skip entries out of patterns range */ \
+ if (in_len > 9) { \
+ gdv_fn_context_set_error_msg(context, "The weekday in this entry is invalid"); \
+ return 0; \
+ } \
+ \
+ char* up = reinterpret_cast<char*>(gdv_fn_context_arena_malloc(context, in_len)); \
Review Comment:
Add a check to see if the malloc operation worked fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13682: ARROW-17171: [C++][Gandiva] Implement case-insensitive
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13682:
URL: https://github.com/apache/arrow/pull/13682#issuecomment-1191928774
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13682: ARROW-17171: [C++][Gandiva] Implement case-insensitive
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13682:
URL: https://github.com/apache/arrow/pull/13682#issuecomment-1191928748
https://issues.apache.org/jira/browse/ARROW-17171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ViniciusSouzaRoque closed pull request #13682: ARROW-17171: [C++][Gandiva] Implement NextDay Function to case-insensitive
Posted by GitBox <gi...@apache.org>.
ViniciusSouzaRoque closed pull request #13682: ARROW-17171: [C++][Gandiva] Implement NextDay Function to case-insensitive
URL: https://github.com/apache/arrow/pull/13682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org