You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Matthias Bläsing <mb...@doppel-helix.eu> on 2018/06/13 17:46:07 UTC

reviews.apache.org - git integration?

Hello,

I just looked at review board and the first thing I'm asking myself:

How do I start a review based on a git branch? "New review request"
requires me to upload a diff, that is not what I want.

This leads me to the question: As a committer I could push a branch
into the netbeans apache repository, but an outside committer would
need to be able to ask the system to pull from a remote source.

Can someone help? Oh and I'm now up to three accounts I need just for
apache... At that point my happiness dropped.

Greetings

Matthias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: reviews.apache.org - git integration?

Posted by Emilian Bold <em...@protonmail.ch.INVALID>.
PS: Note that infra did have to configure the git repository. So... it's doing *something* with git, not just looking at the patch.

--emi

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On 13 June 2018 11:31 PM, Emilian Bold <em...@protonmail.ch> wrote:

> Yes, it seems to be patch-based. You first upload the patch (pre- or post-commit) then you can set the branch this patch is for.
> 
> This is actually something I want to test: does Review Board show the proper diff based on the branch you tell it or does it just show the stuff in the patch? In theory what's in the patch should be enough, but I'm curious if the tool is smart enough to look at git branches.
> 
> It's 'refreshing' that Apache is just like any corporation. Single-sign-on for the random mix of internal tools is truly a herculean task that few accomplish.
> 
> --emi
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> 
> On 13 June 2018 8:46 PM, Matthias Bläsing mblaesing@doppel-helix.eu wrote:
> 
> > Hello,
> > 
> > I just looked at review board and the first thing I'm asking myself:
> > 
> > How do I start a review based on a git branch? "New review request"
> > 
> > requires me to upload a diff, that is not what I want.
> > 
> > This leads me to the question: As a committer I could push a branch
> > 
> > into the netbeans apache repository, but an outside committer would
> > 
> > need to be able to ask the system to pull from a remote source.
> > 
> > Can someone help? Oh and I'm now up to three accounts I need just for
> > 
> > apache... At that point my happiness dropped.
> > 
> > Greetings
> > 
> > Matthias
> > 
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > 
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> > 
> > For further information about the NetBeans mailing lists, visit:
> > 
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: reviews.apache.org - git integration?

Posted by Neil C Smith <ne...@apache.org>.
On Wed, 13 Jun 2018, 19:52 Glenn Holmer, <ce...@kolabnow.com.invalid> wrote:

> On 06/13/2018 01:04 PM, Neil C Smith wrote:
> > Interesting to notice (via GStreamer list) that GNOME and FreeDesktop are
> > moving to providing their own GitLab instances.  I wonder if Apache will
> > take that route at some point?
>
>
> https://about.gitlab.com/2018/06/05/gitlab-ultimate-and-gold-free-for-education-and-open-source/
>
> "GitLab Ultimate is self-hosted, whereas GitLab Gold is our SaaS
> offering hosted on GitLab.com."
>
> Of course, the question remains: what if some people want to use GitLab,
> some GitHub, and some the command line? And what if something happens to
> GitLab or GitHub?
>

Note the key difference that GNOME (and Debian from your link) are self
hosting the open source version of GitLab.

Best wishes,

Neil

> --
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org

Re: reviews.apache.org - git integration?

Posted by Glenn Holmer <ce...@kolabnow.com.INVALID>.
On 06/13/2018 01:04 PM, Neil C Smith wrote:
> Interesting to notice (via GStreamer list) that GNOME and FreeDesktop are
> moving to providing their own GitLab instances.  I wonder if Apache will
> take that route at some point?

https://about.gitlab.com/2018/06/05/gitlab-ultimate-and-gold-free-for-education-and-open-source/

"GitLab Ultimate is self-hosted, whereas GitLab Gold is our SaaS
offering hosted on GitLab.com."

Of course, the question remains: what if some people want to use GitLab,
some GitHub, and some the command line? And what if something happens to
GitLab or GitHub? Those are not easy questions.

-- 
Glenn Holmer (Linux registered user #16682)
"After the vintage season came the aftermath -- and Cenbe."

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: reviews.apache.org - git integration?

Posted by Neil C Smith <ne...@apache.org>.
On Wed, 13 Jun 2018 at 18:46 Matthias Bläsing <mb...@doppel-helix.eu>
wrote:

> Oh and I'm now up to three accounts I need just for
> apache... At that point my happiness dropped.
>
>
 Ha ha ..  I know what you mean! :-)

Interesting to notice (via GStreamer list) that GNOME and FreeDesktop are
moving to providing their own GitLab instances.  I wonder if Apache will
take that route at some point?

Neil
-- 
Neil C Smith
Artist & Technologist
www.neilcsmith.net

Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org

Re: reviews.apache.org - git integration?

Posted by Emilian Bold <em...@protonmail.ch.INVALID>.
Yes, it seems to be patch-based. You first upload the patch (pre- or post-commit) then you can set the branch this patch is for.

This is actually something I want to test: does Review Board show the proper diff based on the branch you tell it or does it just show the stuff in the patch? In theory what's in the patch should be enough, but I'm curious if the tool is smart enough to look at git branches.

It's 'refreshing' that Apache is just like any corporation. Single-sign-on for the random mix of internal tools is truly a herculean task that few accomplish.

--emi

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On 13 June 2018 8:46 PM, Matthias Bläsing <mb...@doppel-helix.eu> wrote:

> Hello,
> 
> I just looked at review board and the first thing I'm asking myself:
> 
> How do I start a review based on a git branch? "New review request"
> 
> requires me to upload a diff, that is not what I want.
> 
> This leads me to the question: As a committer I could push a branch
> 
> into the netbeans apache repository, but an outside committer would
> 
> need to be able to ask the system to pull from a remote source.
> 
> Can someone help? Oh and I'm now up to three accounts I need just for
> 
> apache... At that point my happiness dropped.
> 
> Greetings
> 
> Matthias
> 
> 
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> 
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> 
> For further information about the NetBeans mailing lists, visit:
> 
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: reviews.apache.org - git integration?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Jun 13, 2018 at 7:46 PM Matthias Bläsing
<mb...@doppel-helix.eu> wrote:
> ...I'm now up to three accounts I need just for
> apache... At that point my happiness dropped...

The ASF infra team is working on having everything driven by LDAP, but
that takes some time. Last I heard of it, Jira and Confluence should
be done later this year.

-Bertrand

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists