You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/10/30 10:51:10 UTC
[I] Events link crawling does not work perfectly [whimsy]
potiuk opened a new issue, #280:
URL: https://github.com/apache/whimsy/issues/280
Recently I put a lot of effort in making sure that Airflow website follows the policies of ASF and - unfortunately - despite the effort so far, the Whimsy "event" site does not properly find the "events" link we put on every single page (out of 250K of pages we have) in Airflow website.
When I go to https://whimsy.apache.org/site/project/airflow I see this:
<img width="2030" height="682" alt="Image" src="https://github.com/user-attachments/assets/65bd2110-a034-4e96-9ece-be3be7ece067" />
As you can see - crawling finished recently it seems, and we have still the "events missing" alert, where it's clearly present at all the Airflow doc pages:
The events link is updated in footers on **ALL** pages:
<img width="2032" height="162" alt="Image" src="https://github.com/user-attachments/assets/40b22336-8b88-4772-8242-9110e45517c5" />
and this is the HTML of those pages:
<img width="2032" height="162" alt="Image" src="https://github.com/user-attachments/assets/d8562506-9f5c-4c7b-8cbe-588ebe222959" />
Which seem to be in line with what the check expects (https://events.apache.org/ href) :
```html
<a href="https://events.apache.org/" class="footer-section__policies-section--policy-item">
<span>Events</span>
</a>
```
I would love to get Airflow status "green", unfiratunately I do not know ruby nor whimsy enough to diagnose and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3476920126
Following the VP events and VP marketing (Brian) comment here: https://lists.apache.org/thread/m7vxynrk3lgzlot12s995zzlwgwv63yv - it seems we have all the answers we need and indeed the current way whimsy flags airflow (and possibly other pages) as not having the right "events" link is a bug in whimsy.
Is there anything I can do (not being a ruby developer) to help with fixing it? I guess people like @sebbASF who is apparently checking ASF sites for "correctness" is interested in having the check "correct". We in Airflow are not worried - despite the red flag we know now that this is a false-negative so we can safely ignore it. But if you are checking for "how many sites are wrong" and "what is wrong" - this one might give some skewed numbers, so possibly it's a good idea to fix it.
If there is any way (except contributing to ruby code) I can help, I am happy to - so do let me know.,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3467726564
The preferred way of linking to events is described here:
https://www.apachecon.com/event-images/
This does not include a direct link to https://events.apache.org/.
If you can find the policy that says otherwise, I can change Whimsy accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave closed issue #280: Events link crawling does not work perfectly
URL: https://github.com/apache/whimsy/issues/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3577262345
Airflow is now all green. Looks like this was fixed in 569f3d0cd0e44081489d14cca5ad34a2646f07f4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3470710297
> A PR could be offered to fix this check once policy locations are reviewed.
Absolutely - ideally from someone who knows ruby and understand even remotely how those lines work. It's sad I have no idea about ruby (and no desire to learn it - just to find how to fix potentially one regexp). Unfiortunately, for whimsy I am 10% user - 0% contributor, so best I can do is to provide a good quality issue report and discuss how I understand policies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3467976176
Agreed, but to fix it properly there needs to be a reference to the official policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3469758072
The events site check is here: [sitestandards.rb#L53-L63](https://github.com/apache/whimsy/blob/master/lib/whimsy/sitestandards.rb#L53-L63)
Another issue is that _apachecon.com_ should be removed and any references to that should no longer be compliant.
A PR could be offered to fix this check once policy locations are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3468674127
> Agreed, but to fix it properly there needs to be a reference to the official policy
Well the policy is quite clear, I think it's whimsy check that it's wrong:
> This page contains HTML examples for injecting banners for current Apache events into a project web site.
All Apache project websites SHOULD have a link to upcoming events, and this is the preferred way of doing that.
The policy says (very clearly) that the pages shoudl contain link to upcoming events. And that the banners are preferred (but only preferred). So - as I see it, regexp for `events.apache.org" check fulfills the ` SHOULD have a link to upcoming events`. The "preferred" part is clearly optional (unless I misunderstand what "preferred" word means".
That's why I believe whimsy descriptin of the error and regexp explained as "way of checking" it is correct and whimsy should do what it explains it's doing. There is an inconsistency here - because despite matching the regular expression and actually the airflow.apache.org "having a link to upcoming events" (it does as policy explains) whimsy flags it as an error - so something is wrong (possibly a technical issue) with the check in whimsy.
Would you agree with this way of explaining it - and if not - which part of it?
So my suggestion is to make the check follow the existing policy where the only SHOULD is about having link, rather than expecting the "preferred" way of doing it. Would you agree with it? Or you would like to propose other solution?
I think all three things are clear:
1) policy expects a link and suggest a way how the link could be done
2) whimsy error description seems to agree with that
but
3) there is apparently an error with implementing 2) that produces red status
So my proposal is to find and fix the technical issue.
Is there some flaw or misunderstanding in this proposal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3467958853
This is what the error description explains - so the error description is apparently inconsistent with the page that it links to:
<img width="1804" height="894" alt="Image" src="https://github.com/user-attachments/assets/aa1a3274-63de-44fa-bd70-5ae91ac21c25" />
URL expected to match regular expression: ^https?://((www\.)?apache\.org/events/current-event|events\.apache\.org|www\.apachecon\.com/event-images/snippet\.js)
[Projects SHOULD include a link to any current CommunityOverCode event, or to the events.apache.org site, as provided by VP, Conferences.](https://www.apachecon.com/event-images/)
The regular expression contains `events\.apache\.org` - also links title suggest that "or the events.apache.org" is a viable way of linking.
I think it would be good to clarify it in one or the other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3469031309
If you need some validation for it @sebbASF -> we can even ask the VP Events to clarify, but I woudl love to understand what's your point of view - as I thin both policy and current implementation of our links are in agreement - same as the description of the issue. The only problem is the "red" status of the check which is quite puzzling to be honest taking into account the actual description of the error.
What do you think @sebbASF ? Is there something unclear to you that we need to reach-out to VP events, or is my explanation convincing enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Events link crawling does not work perfectly [whimsy]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #280:
URL: https://github.com/apache/whimsy/issues/280#issuecomment-3577326053
Thanks. yes. Fantastic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org