You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@gmail.com on 2011/08/02 02:28:38 UTC
Review Request: Split deferJs() functionality into its own method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1237/
-----------------------------------------------------------
Review request for shindig and Michael Hermanto.
Summary
-------
The previous model of using exportJs() for both deferred and actual symbol exports turned out to be faulty due to the fact that top-level/global arguments are not properties. As well, splitting export() and defer() makes the relevant functionality more compact where actually used, and more explicit.
This CL reverts the exportJs() changes that bind deferred symbols, though keeps the deferred method execution intact.
It splits out deferred symbol binding into a new method, deferJs(), while doing so. The two methods work in concert with one another, communicating through ___jsl.dm.
Diffs
-----
trunk/features/src/main/javascript/features/deferjs/deferjs.js PRE-CREATION
trunk/features/src/main/javascript/features/deferjs/feature.xml PRE-CREATION
trunk/features/src/main/javascript/features/exportjs/exportjs.js 1152380
Diff: https://reviews.apache.org/r/1237/diff
Testing
-------
CL sent for early review. Doing more testing now in real-world scenarios.
Thanks,
johnfargo
Re: Review Request: Split deferJs() functionality into its own method
Posted by Ziv Horesh <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1237/#review1258
-----------------------------------------------------------
Ship it!
Thanks for the offline explanation.
Using a queue for each function, the defer function (which injected by a js processor TBD) basically add args to queue.
When a feature is loaded, all queued requests are activated (by the exportJs function).
- Ziv
On 2011-08-02 00:57:26, johnfargo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1237/
> -----------------------------------------------------------
>
> (Updated 2011-08-02 00:57:26)
>
>
> Review request for shindig and Michael Hermanto.
>
>
> Summary
> -------
>
> The previous model of using exportJs() for both deferred and actual symbol exports turned out to be faulty due to the fact that top-level/global arguments are not properties. As well, splitting export() and defer() makes the relevant functionality more compact where actually used, and more explicit.
>
> This CL reverts the exportJs() changes that bind deferred symbols, though keeps the deferred method execution intact.
>
> It splits out deferred symbol binding into a new method, deferJs(), while doing so. The two methods work in concert with one another, communicating through ___jsl.dm.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/deferjs/deferjs.js PRE-CREATION
> trunk/features/src/main/javascript/features/deferjs/feature.xml PRE-CREATION
> trunk/features/src/main/javascript/features/exportjs/exportjs.js 1152380
> trunk/features/src/main/javascript/features/features.txt 1152380
>
> Diff: https://reviews.apache.org/r/1237/diff
>
>
> Testing
> -------
>
> CL sent for early review. Doing more testing now in real-world scenarios.
>
>
> Thanks,
>
> johnfargo
>
>
Re: Review Request: Split deferJs() functionality into its own method
Posted by John Hjelmstad <fa...@google.com>.
Thanks! Will commit after yours :)
On Tue, Aug 2, 2011 at 1:09 PM, Michael Hermanto <mh...@gmail.com>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1237/#review1271
> -----------------------------------------------------------
>
> Ship it!
>
>
> ... upon fix.
>
> - Michael
>
>
> On 2011-08-02 00:57:26, johnfargo wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/1237/
> > -----------------------------------------------------------
> >
> > (Updated 2011-08-02 00:57:26)
> >
> >
> > Review request for shindig and Michael Hermanto.
> >
> >
> > Summary
> > -------
> >
> > The previous model of using exportJs() for both deferred and actual
> symbol exports turned out to be faulty due to the fact that top-level/global
> arguments are not properties. As well, splitting export() and defer() makes
> the relevant functionality more compact where actually used, and more
> explicit.
> >
> > This CL reverts the exportJs() changes that bind deferred symbols, though
> keeps the deferred method execution intact.
> >
> > It splits out deferred symbol binding into a new method, deferJs(), while
> doing so. The two methods work in concert with one another, communicating
> through ___jsl.dm.
> >
> >
> > Diffs
> > -----
> >
> > trunk/features/src/main/javascript/features/deferjs/deferjs.js
> PRE-CREATION
> > trunk/features/src/main/javascript/features/deferjs/feature.xml
> PRE-CREATION
> > trunk/features/src/main/javascript/features/exportjs/exportjs.js
> 1152380
> > trunk/features/src/main/javascript/features/features.txt 1152380
> >
> > Diff: https://reviews.apache.org/r/1237/diff
> >
> >
> > Testing
> > -------
> >
> > CL sent for early review. Doing more testing now in real-world scenarios.
> >
> >
> > Thanks,
> >
> > johnfargo
> >
> >
>
>
Re: Review Request: Split deferJs() functionality into its own method
Posted by Michael Hermanto <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1237/#review1271
-----------------------------------------------------------
Ship it!
... upon fix.
- Michael
On 2011-08-02 00:57:26, johnfargo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1237/
> -----------------------------------------------------------
>
> (Updated 2011-08-02 00:57:26)
>
>
> Review request for shindig and Michael Hermanto.
>
>
> Summary
> -------
>
> The previous model of using exportJs() for both deferred and actual symbol exports turned out to be faulty due to the fact that top-level/global arguments are not properties. As well, splitting export() and defer() makes the relevant functionality more compact where actually used, and more explicit.
>
> This CL reverts the exportJs() changes that bind deferred symbols, though keeps the deferred method execution intact.
>
> It splits out deferred symbol binding into a new method, deferJs(), while doing so. The two methods work in concert with one another, communicating through ___jsl.dm.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/deferjs/deferjs.js PRE-CREATION
> trunk/features/src/main/javascript/features/deferjs/feature.xml PRE-CREATION
> trunk/features/src/main/javascript/features/exportjs/exportjs.js 1152380
> trunk/features/src/main/javascript/features/features.txt 1152380
>
> Diff: https://reviews.apache.org/r/1237/diff
>
>
> Testing
> -------
>
> CL sent for early review. Doing more testing now in real-world scenarios.
>
>
> Thanks,
>
> johnfargo
>
>
Re: Review Request: Split deferJs() functionality into its own method
Posted by John Hjelmstad <fa...@google.com>.
Good catch, done
On Tue, Aug 2, 2011 at 1:07 PM, Michael Hermanto <mh...@gmail.com>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1237/#review1270
> -----------------------------------------------------------
>
>
>
> trunk/features/src/main/javascript/features/features.txt
> <https://reviews.apache.org/r/1237/#comment2903>
>
> s/deferJs/deferjs/
> - deferjs.js is in deferjs/ dir.
> - consistent with exportjs.
>
>
>
> - Michael
>
>
> On 2011-08-02 00:57:26, johnfargo wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/1237/
> > -----------------------------------------------------------
> >
> > (Updated 2011-08-02 00:57:26)
> >
> >
> > Review request for shindig and Michael Hermanto.
> >
> >
> > Summary
> > -------
> >
> > The previous model of using exportJs() for both deferred and actual
> symbol exports turned out to be faulty due to the fact that top-level/global
> arguments are not properties. As well, splitting export() and defer() makes
> the relevant functionality more compact where actually used, and more
> explicit.
> >
> > This CL reverts the exportJs() changes that bind deferred symbols, though
> keeps the deferred method execution intact.
> >
> > It splits out deferred symbol binding into a new method, deferJs(), while
> doing so. The two methods work in concert with one another, communicating
> through ___jsl.dm.
> >
> >
> > Diffs
> > -----
> >
> > trunk/features/src/main/javascript/features/deferjs/deferjs.js
> PRE-CREATION
> > trunk/features/src/main/javascript/features/deferjs/feature.xml
> PRE-CREATION
> > trunk/features/src/main/javascript/features/exportjs/exportjs.js
> 1152380
> > trunk/features/src/main/javascript/features/features.txt 1152380
> >
> > Diff: https://reviews.apache.org/r/1237/diff
> >
> >
> > Testing
> > -------
> >
> > CL sent for early review. Doing more testing now in real-world scenarios.
> >
> >
> > Thanks,
> >
> > johnfargo
> >
> >
>
>
Re: Review Request: Split deferJs() functionality into its own method
Posted by Michael Hermanto <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1237/#review1270
-----------------------------------------------------------
trunk/features/src/main/javascript/features/features.txt
<https://reviews.apache.org/r/1237/#comment2903>
s/deferJs/deferjs/
- deferjs.js is in deferjs/ dir.
- consistent with exportjs.
- Michael
On 2011-08-02 00:57:26, johnfargo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1237/
> -----------------------------------------------------------
>
> (Updated 2011-08-02 00:57:26)
>
>
> Review request for shindig and Michael Hermanto.
>
>
> Summary
> -------
>
> The previous model of using exportJs() for both deferred and actual symbol exports turned out to be faulty due to the fact that top-level/global arguments are not properties. As well, splitting export() and defer() makes the relevant functionality more compact where actually used, and more explicit.
>
> This CL reverts the exportJs() changes that bind deferred symbols, though keeps the deferred method execution intact.
>
> It splits out deferred symbol binding into a new method, deferJs(), while doing so. The two methods work in concert with one another, communicating through ___jsl.dm.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/deferjs/deferjs.js PRE-CREATION
> trunk/features/src/main/javascript/features/deferjs/feature.xml PRE-CREATION
> trunk/features/src/main/javascript/features/exportjs/exportjs.js 1152380
> trunk/features/src/main/javascript/features/features.txt 1152380
>
> Diff: https://reviews.apache.org/r/1237/diff
>
>
> Testing
> -------
>
> CL sent for early review. Doing more testing now in real-world scenarios.
>
>
> Thanks,
>
> johnfargo
>
>
Re: Review Request: Split deferJs() functionality into its own method
Posted by jo...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1237/
-----------------------------------------------------------
(Updated 2011-08-02 00:57:26.689862)
Review request for shindig and Michael Hermanto.
Changes
-------
Adding features.txt entry.
Summary
-------
The previous model of using exportJs() for both deferred and actual symbol exports turned out to be faulty due to the fact that top-level/global arguments are not properties. As well, splitting export() and defer() makes the relevant functionality more compact where actually used, and more explicit.
This CL reverts the exportJs() changes that bind deferred symbols, though keeps the deferred method execution intact.
It splits out deferred symbol binding into a new method, deferJs(), while doing so. The two methods work in concert with one another, communicating through ___jsl.dm.
Diffs (updated)
-----
trunk/features/src/main/javascript/features/deferjs/deferjs.js PRE-CREATION
trunk/features/src/main/javascript/features/deferjs/feature.xml PRE-CREATION
trunk/features/src/main/javascript/features/exportjs/exportjs.js 1152380
trunk/features/src/main/javascript/features/features.txt 1152380
Diff: https://reviews.apache.org/r/1237/diff
Testing
-------
CL sent for early review. Doing more testing now in real-world scenarios.
Thanks,
johnfargo