You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/08/02 03:44:04 UTC
Re: Review Request 11975: Use hostname instead of IP for redirection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11975/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 1:44 a.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Repository: mesos
Description
-------
Use hostname instead of IP for redirection.
In the Web UI, the redirection does not work for hosts where the local
interface address is not publicly accessible. For example, with EC2 the
redirection will not work.
This change writes the Master's hostname into ZooKeeper, thereby
allowing the redirection to work with private IP addresses.
Review: https://reviews.apache.org/r/11975/
Diffs (updated)
-----
src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0
src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
src/master/http.cpp ca66d6782023d303c8acc89ef9cf421cfca8d0dc
src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d
src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad
src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
src/sched/sched.cpp 5718fe9280d7e1124ffef2de9e4d47b347f0600a
src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301
src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b
Diff: https://reviews.apache.org/r/11975/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 11975: Use hostname instead of IP for redirection.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11975/#review36712
-----------------------------------------------------------
Bad patch!
Reviews applied: [11975]
Failed command: git apply --index 11975.patch
Error:
error: src/detector/detector.hpp: does not exist in index
error: src/detector/detector.cpp: does not exist in index
error: patch failed: src/local/local.cpp:124
error: src/local/local.cpp: patch does not apply
error: patch failed: src/master/http.cpp:276
error: src/master/http.cpp: patch does not apply
error: patch failed: src/master/main.cpp:123
error: src/master/main.cpp: patch does not apply
error: patch failed: src/master/master.hpp:82
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/master.cpp:327
error: src/master/master.cpp: patch does not apply
error: patch failed: src/messages/messages.proto:332
error: src/messages/messages.proto: patch does not apply
error: patch failed: src/sched/sched.cpp:111
error: src/sched/sched.cpp: patch does not apply
error: patch failed: src/slave/main.cpp:132
error: src/slave/main.cpp: patch does not apply
error: patch failed: src/tests/cluster.hpp:228
error: src/tests/cluster.hpp: patch does not apply
error: src/tests/master_detector_tests.cpp: does not exist in index
error: patch failed: src/webui/master/static/js/controllers.js:124
error: src/webui/master/static/js/controllers.js: patch does not apply
- Mesos ReviewBot
On Oct. 22, 2013, 7:03 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11975/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 7:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use hostname instead of IP for redirection.
>
> In the Web UI, the redirection does not work for hosts where the local
> interface address is not publicly accessible. For example, with EC2 the
> redirection will not work.
>
> This change writes the Master's hostname into ZooKeeper, thereby
> allowing the redirection to work with private IP addresses.
>
> Review: https://reviews.apache.org/r/11975/
>
>
> Diffs
> -----
>
> src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0
> src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
> src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
> src/master/http.cpp ca66d6782023d303c8acc89ef9cf421cfca8d0dc
> src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
> src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d
> src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad
> src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
> src/sched/sched.cpp 5718fe9280d7e1124ffef2de9e4d47b347f0600a
> src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301
> src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
> src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
> src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b
>
> Diff: https://reviews.apache.org/r/11975/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11975: Use hostname instead of IP for redirection.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11975/#review36710
-----------------------------------------------------------
Is this patch still relevant or can it be dropped?
- Niklas Nielsen
On Oct. 22, 2013, 12:03 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11975/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 12:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use hostname instead of IP for redirection.
>
> In the Web UI, the redirection does not work for hosts where the local
> interface address is not publicly accessible. For example, with EC2 the
> redirection will not work.
>
> This change writes the Master's hostname into ZooKeeper, thereby
> allowing the redirection to work with private IP addresses.
>
> Review: https://reviews.apache.org/r/11975/
>
>
> Diffs
> -----
>
> src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0
> src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
> src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
> src/master/http.cpp ca66d6782023d303c8acc89ef9cf421cfca8d0dc
> src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
> src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d
> src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad
> src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
> src/sched/sched.cpp 5718fe9280d7e1124ffef2de9e4d47b347f0600a
> src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301
> src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
> src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
> src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b
>
> Diff: https://reviews.apache.org/r/11975/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11975: Use hostname instead of IP for redirection.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11975/
-----------------------------------------------------------
(Updated Oct. 22, 2013, 7:03 p.m.)
Review request for mesos.
Changes
-------
I can't update the diff for this:
brenden@airbob ~/dev/mesos $ git cherry-pick a63fad4ca8cd0d4a735db31bf62d710a92baa0e6
[am 41be4e4] Use hostname instead of IP for redirection.
13 files changed, 181 insertions(+), 88 deletions(-)
brenden@airbob ~/dev/mesos $ ./support/post-reviews.py --target-groups=mesos --guess-fields
Running post-review across all of ...
41be4e47189c968365cb1d3193b72cf20c190836 - (HEAD, am) Use hostname instead of IP for redirection. (1 second ago)
Updating diff of:
41be4e47189c968365cb1d3193b72cf20c190836 - (HEAD, am) Use hostname instead of IP for redirection. (2 seconds ago)
... with parent diff created from:
Press enter to continue or 'Ctrl-C' to skip.
Failed to execute: 'post-review --review-request-id=11975 --repository-url=git://git.apache.org/mesos.git --tracking-branch=master --revision-range=master:41be4e47189c968365cb1d3193b72cf20c190836 --target-groups=mesos --guess-fields':
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
brenden@airbob ~/dev/mesos $
The code is available here, however:
https://github.com/airbnb/mesos/commit/a63fad4ca8cd0d4a735db31bf62d710a92baa0e6
Repository: mesos
Description
-------
Use hostname instead of IP for redirection.
In the Web UI, the redirection does not work for hosts where the local
interface address is not publicly accessible. For example, with EC2 the
redirection will not work.
This change writes the Master's hostname into ZooKeeper, thereby
allowing the redirection to work with private IP addresses.
Review: https://reviews.apache.org/r/11975/
Diffs
-----
src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0
src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
src/master/http.cpp ca66d6782023d303c8acc89ef9cf421cfca8d0dc
src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d
src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad
src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
src/sched/sched.cpp 5718fe9280d7e1124ffef2de9e4d47b347f0600a
src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301
src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526
src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b
Diff: https://reviews.apache.org/r/11975/diff/
Testing
-------
make check
Thanks,
Brenden Matthews