You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/09/20 17:07:55 UTC

[commons-statistics] 07/13: Use ParameterizedTest for addition Cauchy test cases

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 3809a28b7da3520d1425aec73e993e68a5625abf
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Sep 20 15:08:42 2021 +0100

    Use ParameterizedTest for addition Cauchy test cases
---
 .../distribution/CauchyDistributionTest.java       | 48 ++++++++++++----------
 1 file changed, 26 insertions(+), 22 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
index 7b6835b..74f8a2f 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
@@ -20,6 +20,8 @@ package org.apache.commons.statistics.distribution;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 
 /**
  * Test cases for CauchyDistribution.
@@ -94,32 +96,34 @@ class CauchyDistributionTest extends ContinuousDistributionAbstractTest {
         verifyInverseCumulativeProbabilities();
     }
 
-    @Test
-    void testParameterAccessors() {
-        final CauchyDistribution dist = makeDistribution();
-        Assertions.assertEquals(1.2, dist.getLocation());
-        Assertions.assertEquals(2.1, dist.getScale());
+    @ParameterizedTest
+    @CsvSource({
+        "1.2, 2.1",
+        "0, 1",
+        "-3, 2",
+    })
+    void testParameterAccessors(double location, double scale) {
+        final CauchyDistribution dist = new CauchyDistribution(location, scale);
+        Assertions.assertEquals(location, dist.getLocation());
+        Assertions.assertEquals(scale, dist.getScale());
     }
 
-    @Test
-    void testConstructorPrecondition1() {
-        Assertions.assertThrows(DistributionException.class, () -> new CauchyDistribution(0, 0));
-    }
-
-    @Test
-    void testConstructorPrecondition2() {
-        Assertions.assertThrows(DistributionException.class, () -> new CauchyDistribution(0, -1));
+    @ParameterizedTest
+    @CsvSource({
+        "0, 0",
+        "0, -1",
+    })
+    void testConstructorPreconditions(double location, double scale) {
+        Assertions.assertThrows(DistributionException.class, () -> new CauchyDistribution(location, scale));
     }
 
-    @Test
-    void testMoments() {
-        CauchyDistribution dist;
-
-        dist = new CauchyDistribution(10.2, 0.15);
-        Assertions.assertTrue(Double.isNaN(dist.getMean()));
-        Assertions.assertTrue(Double.isNaN(dist.getVariance()));
-
-        dist = new CauchyDistribution(23.12, 2.12);
+    @ParameterizedTest
+    @CsvSource({
+        "10.2, 0.15",
+        "23.12, 2.12",
+    })
+    void testMoments(double location, double scale) {
+        final CauchyDistribution dist = new CauchyDistribution(location, scale);
         Assertions.assertTrue(Double.isNaN(dist.getMean()));
         Assertions.assertTrue(Double.isNaN(dist.getVariance()));
     }