You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "AlinsRan (via GitHub)" <gi...@apache.org> on 2023/05/10 00:57:48 UTC

[GitHub] [apisix] AlinsRan opened a new pull request, #9450: fix: failed to configure `key: mqtt_client_id` using upstream

AlinsRan opened a new pull request, #9450:
URL: https://github.com/apache/apisix/pull/9450

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes #9449 
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] AlinsRan commented on pull request #9450: fix: failed to configure `key: mqtt_client_id` using upstream

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on PR #9450:
URL: https://github.com/apache/apisix/pull/9450#issuecomment-1545402145

   > There are many variables and we cannot list them all. how about rewrite like this: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L454
   
   I think constraints are necessary because they can help users follow the best practices.
   Under constraints, many situations are predictable. Flexibility is not about more options, but about better options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9450: fix: failed to configure `key: mqtt_client_id` using upstream

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9450:
URL: https://github.com/apache/apisix/pull/9450#issuecomment-1541760989

   There are many variables and we cannot list them all.
   how about rewrite like this: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L454


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang merged pull request #9450: fix: upstream `key` config add `mqtt_client_id` support

Posted by "leslie-tsang (via GitHub)" <gi...@apache.org>.
leslie-tsang merged PR #9450:
URL: https://github.com/apache/apisix/pull/9450


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org