You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 10:29:40 UTC

[GitHub] [arrow] AlenkaF opened a new pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

AlenkaF opened a new pull request #11900:
URL: https://github.com/apache/arrow/pull/11900


   We would like to add a **Tutorial** on how to **add a simple feature to PyArrow** that would be a part of the (New) Contributor's Guide.
   
   For this reason I made up a feature called `tutorial_min_max` that I added to `compute.py` plus a unit test to `test_compute.py.` The steps of making this PR will be added to the guide content separately [ARROW-14602](https://issues.apache.org/jira/browse/ARROW-14602.)
   
   cc @jorisvandenbossche @amol- @dragosmg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-988877711


   Tipically there are three kinds of patches go to pyarrow:
   
   1. Plain python change like this example which doesn't require rebuilding pyarrow.
   2. Cython change touching `.pxi`, `.pyx`, `.pxd` files which requires rebuilding pyarrow (e.g. fixing something or exposing new libarrow functionality)
   3. C++ change along with Cython change where we add new code to libarrow[_python] too where we need to rebuild the C++ libraries as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-988750767


   @kszucs I think that would be a good idea. Do you have any in mind?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-994620493


   @kszucs do you think this initial PR could be done first and then we can add two more examples in the second version of the Guide?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-988688603


   https://issues.apache.org/jira/browse/ARROW-14977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-989182504


   I think we can locate already merged commits for the three separate cases and translate/simplify those to a material suitable for tutorials. Cc @jorisvandenbossche 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-988733876


   Do we plan to add an example using cython as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-988971940


   Thank you for such a good summary.
   
   I was thinking more specifically. It seems harder, at first glance, to make a simple example for cython - I will think of something, suggestions are welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11900:
URL: https://github.com/apache/arrow/pull/11900#issuecomment-1000238017


   Closing this PR as the [tutorial](https://github.com/apache/arrow/pull/11913) is merged and this will stay an example PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF closed pull request #11900: ARROW-14977: [Python] Add a "made-up" feature for the guide tutorial

Posted by GitBox <gi...@apache.org>.
AlenkaF closed pull request #11900:
URL: https://github.com/apache/arrow/pull/11900


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org