You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iotdb.apache.org by Jialin Qiao <qi...@apache.org> on 2022/09/19 09:35:08 UTC

Add COMMITID file in distribution

Hi,

Some users may directly package the master or rel branch.
To identify their version, we plan to add a COMMITID file when packaging.

https://github.com/apache/iotdb/pull/7316

Thanks,
—————————————————
Jialin Qiao
Apache IoTDB PMC

Re: Add COMMITID file in distribution

Posted by Eric Pai <er...@hotmail.com>.

Hi,

Commit ID is really important in distribution, especially in testing/online environment debugging. However, I think it's more convenient to query it through CLI, not only including the commit id in a server-side file.
What's more, if we only rely on the head commit id, when a IoTDB distribution is built with some uncommitted changes, it will also display the same commit, which may confuse us in the debugging. We should separate the dirty build and clean build as well.

So I submit another PR to achieve this.

https://github.com/apache/iotdb/pull/7365

You can see the examples in JIRA: https://issues.apache.org/jira/browse/IOTDB-4454

在 2022/9/19 17:35，“Jialin Qiao”<qi...@apache.org> 写入:

    Hi,

    Some users may directly package the master or rel branch.
    To identify their version, we plan to add a COMMITID file when packaging.

    https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fiotdb%2Fpull%2F7316&amp;data=05%7C01%7C%7Cafa6d8e95e2147c0e21608da9a224726%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637991769261197284%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Ny%2BGPPAM7vzovU6%2FnVb7tGRaJkslAKzr%2Ff3CFulxwKs%3D&amp;reserved=0

    Thanks,
    —————————————————
    Jialin Qiao
    Apache IoTDB PMC