You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/12/06 18:49:51 UTC
[GitHub] [geode] kirklund opened pull request #2961: GEODE-6154:
Remove optional from geode-core spring-shell dependency
[ Full content available at: https://github.com/apache/geode/pull/2961 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #2961: GEODE-6154:
Remove optional from geode-core spring-shell dependency
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2961 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #2961: GEODE-6154:
Remove optional from geode-core spring-shell dependency
Posted by "kirklund (GitHub)" <gi...@apache.org>.
Trigger another precheckin
[ Full content available at: https://github.com/apache/geode/pull/2961 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #2961:
GEODE-6154: Remove optional from geode-core spring-shell dependency
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
I think we should approve #2915 and start building out BOMs. The module POMs should probably have all dependencies necessary to use all edge cases in the module. The BOMs can then filter the modules for specific workloads. The only things left as optional could be things that are truly optional, like maybe some log appenders or something.
[ Full content available at: https://github.com/apache/geode/pull/2961 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on issue #2961:
GEODE-6154: Remove optional from geode-core spring-shell dependency
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
I put a comment on your JIRA - it seems that ClientCacheFactory actually doesn't require spring shell - just the way you are creating a client, thanks to some crazy if checks.
That said, this is still a mess. Seems like we should remove all of the optional flags, maybe? Or actually refactor these management related dependencies out of geode-core!
[ Full content available at: https://github.com/apache/geode/pull/2961 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org