You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/01/24 16:47:01 UTC
[GitHub] [arrow] westonpace opened a new issue, #33850: [C++] Allow Substrait's default extension provider to be configured
westonpace opened a new issue, #33850:
URL: https://github.com/apache/arrow/issues/33850
### Describe the enhancement requested
A custom extension provider can be specified when running a query. However, in some cases (e.g. when Acero is embedded in a larger program that provides its own extension handlers) it would be simpler to change the default instead of having to specify the custom provider with every query run.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1416401591
You mean like a mutex / lock_guard? Yes, that would be a good idea. Or am I misunderstanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1412743184
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1416373076
We're on the same page on that. My question is whether we need anything more, like some kind of guard, in the implementation of the API for setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace closed issue #33850: [C++] Allow Substrait's default extension provider to be configured
URL: https://github.com/apache/arrow/issues/33850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1415966791
IMO `kDefaultExtensionProvider` is not a public API so we should not change it directly. The API can be as simple as changing that variable under the hood but we still need a nice public API for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1416406168
Yes, and wanted to make sure there's nothing else needed that I might be missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1415774225
@westonpace, @icexelloss, this issue may be a no-op, because [`ExtensionProvider::kDefaultExtensionProvider` is public](https://github.com/apache/arrow/blob/177a0d4400e61f44dbd045ce05150bba28dd1d74/cpp/src/arrow/engine/substrait/options.h#L77) and can already be directly set. We could have some kind of guarding around its setting, if desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1416363252
I agree with @icexelloss . We should move `kDefaultExtensionProvider` into the `.cc` file and/or make it const.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #33850: [C++] Allow Substrait's default extension provider to be configured
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #33850:
URL: https://github.com/apache/arrow/issues/33850#issuecomment-1416411573
I think that would be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org