You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/05 12:50:32 UTC

[GitHub] [calcite] vlsi commented on pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

vlsi commented on pull request #2313:
URL: https://github.com/apache/calcite/pull/2313#issuecomment-754616056


   Looks good to me, however `rexBuilder.getTypeFactory()` might be de-duplicated to its own variable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org