You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/15 04:49:58 UTC

[GitHub] [cordova-plugin-statusbar] breautek opened a new pull request #172: (android) Remember statusbar color during overlay state changes

breautek opened a new pull request #172: (android) Remember statusbar color during overlay state changes
URL: https://github.com/apache/cordova-plugin-statusbar/pull/172
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Statusbar would override background color to set transparent on `overlaysWebView(true)` and therefore `overlaysWebView(false)` will make the statusbar turn black.
   
   This PR keeps track of the background color, in both states so that 
   Fixes #159 
   
   ### Description
   <!-- Describe your changes in detail -->
   Two variables were added to keep the background color in memory, one for the solid statusbar and another for overlayed statusbar.
   
   Calling on `backgroundColorByHexString` will determine if the statusbar is overlayed and will update the respective variables.
   
   `setStatusBarTransparent` has been changed so that it now doesn't hard code the statusbar colour and instead will use the variables to change the statusbar color.
   
   By default, the overlay background color defaults to `#00000000` (in otherwords, fully transparent). This makes it so, calling on `overlaysWebview(true)` will hide the statusbar, as it always did before. The overlay background color can be set by supplying a #AARRGGBB hex format to `StatusBarBackgroundColor` preference.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   `npm test` and manual testing.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org