You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/12 13:43:12 UTC

[GitHub] [netbeans] sdedic commented on pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs

sdedic commented on pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306#issuecomment-672878728


   Very nice catch! Indeed, the Compat class was (conceptually) broken from the initial refactor. The issue was hidden until 9f47905f7 which removed the (now obsolete) `getActions()` implementation from the `BinaryFS` ... and even after until some old-API client was REALLY loaded at runtime.
   
   So it seems that as a rule of thumb, the compat class should have ***no*** abstract methods in it. The `@PatchFor` processor could enforce that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists