You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2014/08/05 13:08:08 UTC
Review Request 24307: QPID-5948: extended fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24307/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher and Kim van der Riet.
Bugs: QPID-5948
https://issues.apache.org/jira/browse/QPID-5948
Repository: qpid
Description
-------
Suggested expansion of fix in https://reviews.apache.org/r/24251 to: (a) handle more general exceptions and (b) to prevent the condition in the first place by requiring that the exchange backing a durable topic is also durable.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/ObjectFactory.cpp 1615699
/trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1615699
Diff: https://reviews.apache.org/r/24307/diff/
Testing
-------
Thanks,
Gordon Sim
Re: Review Request 24307: QPID-5948: extended fix
Posted by Kim van der Riet <ki...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24307/#review49746
-----------------------------------------------------------
Ship it!
Ship It!
- Kim van der Riet
On Aug. 5, 2014, 11:08 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24307/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 11:08 a.m.)
>
>
> Review request for qpid, Andrew Stitcher and Kim van der Riet.
>
>
> Bugs: QPID-5948
> https://issues.apache.org/jira/browse/QPID-5948
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Suggested expansion of fix in https://reviews.apache.org/r/24251 to: (a) handle more general exceptions and (b) to prevent the condition in the first place by requiring that the exchange backing a durable topic is also durable.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ObjectFactory.cpp 1615699
> /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1615699
>
> Diff: https://reviews.apache.org/r/24307/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 24307: QPID-5948: extended fix
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24307/#review49598
-----------------------------------------------------------
Ship it!
I think this is along the right lines.
- Andrew Stitcher
On Aug. 5, 2014, 11:08 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24307/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 11:08 a.m.)
>
>
> Review request for qpid, Andrew Stitcher and Kim van der Riet.
>
>
> Bugs: QPID-5948
> https://issues.apache.org/jira/browse/QPID-5948
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Suggested expansion of fix in https://reviews.apache.org/r/24251 to: (a) handle more general exceptions and (b) to prevent the condition in the first place by requiring that the exchange backing a durable topic is also durable.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ObjectFactory.cpp 1615699
> /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1615699
>
> Diff: https://reviews.apache.org/r/24307/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>