[GitHub] [incubator-doris] morningman commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r415874642



##########
File path: be/src/exec/exec_node.cpp
##########
@@ -339,7 +337,7 @@ Status ExecNode::create_tree_helper(
     }
 
     if (!node->_children.empty()) {
-        node->runtime_profile()->add_child(node->_children[0]->runtime_profile(), false, NULL);

Review comment:
       It seem that the `false` here is to distinguish child[0] and other children.
   Are you sure this is more readable? You can put the result screenshots here to explain.

##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -702,8 +694,13 @@ Status OlapScanNode::start_scan_thread(RuntimeState* state) {
                 state, this, _olap_scan_node.is_preaggregation, _need_agg_finalize, *scan_range, scanner_ranges);
             _scanner_pool->add(scanner);
             _olap_scanners.push_back(scanner);
+
+            if (disk_set.find(scanner->scan_disk()) == disk_set.end()) {
+                disk_set.insert(scanner->scan_disk());

Review comment:
       `disk_set` is a set, so no need to `find and insert`, just `insert` is OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org