You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/24 09:20:20 UTC
[GitHub] [iceberg] wynjauu opened a new issue #2369: Flink : the construction method of the class DataIterator can be optimized
wynjauu opened a new issue #2369:
URL: https://github.com/apache/iceberg/issues/2369
In the code block marked in the above figure, the implementation process of the code block for the initialization value of the **inputFiles** variable can be further optimized, streamlined, and reduce multiple loops.At the same time, the code will be more elegant.
I optimized the code as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhuxiaoshang commented on issue #2369: Flink : the construction method of the class DataIterator can be optimized
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on issue #2369:
URL: https://github.com/apache/iceberg/issues/2369#issuecomment-805638066
Good Job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed issue #2369: Flink : the construction method of the class DataIterator can be optimized
Posted by GitBox <gi...@apache.org>.
rdblue closed issue #2369:
URL: https://github.com/apache/iceberg/issues/2369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #2369: Flink : the construction method of the class DataIterator can be optimized
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #2369:
URL: https://github.com/apache/iceberg/issues/2369#issuecomment-806071210
I'm closing this because I don't think the refactor is a good idea. More details are on the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhuxiaoshang edited a comment on issue #2369: Flink : the construction method of the class DataIterator can be optimized
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang edited a comment on issue #2369:
URL: https://github.com/apache/iceberg/issues/2369#issuecomment-805638066
Nice Catch.Good Job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org