You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2023/02/09 21:47:12 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request, #29450: Rename `db export-cleaned` to `db export-archived`
ephraimbuddy opened a new pull request, #29450:
URL: https://github.com/apache/airflow/pull/29450
This is more appropriate because what is exported are the contents of the archived tables. Even though the contents are the cleaned data, they are still archived and we are 'exporting' from the archived tables.
This also aligns with the `--drop-archives` option and `db drop-archived` command in terms of naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #29450: Rename `db export-cleaned` to `db export-archived`
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #29450:
URL: https://github.com/apache/airflow/pull/29450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #29450: Rename `db export-cleaned` to `db export-archived`
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #29450:
URL: https://github.com/apache/airflow/pull/29450#issuecomment-1447186807
This is a new feature, hasn't been in a release yet, #29058. It should definitely be in 2.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29450: Rename `db export-cleaned` to `db export-archived`
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29450:
URL: https://github.com/apache/airflow/pull/29450#discussion_r1102859688
##########
docs/apache-airflow/howto/usage-cli.rst:
##########
@@ -219,7 +219,7 @@ By default, ``db clean`` will archive purged rows in tables of the form ``_airfl
Export the purged records from the archive tables
-------------------------------------------------
-The ``db export-cleaned`` command exports the contents of the archived tables, created by the ``db clean`` command,
+The ``db export-archived`` command exports the contents of the archived tables, created by the ``db clean`` command,
Review Comment:
There is another reference down in the dropping section as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #29450: Rename `db export-cleaned` to `db export-archived`
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #29450:
URL: https://github.com/apache/airflow/pull/29450#issuecomment-1447104710
Wondering if this is fine for next minor (2.6.0) or if we should push it to 3.0.0. (`db export-clean` will just stop working here, should we add a significant fragment as well ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #29450: Rename `db export-cleaned` to `db export-archived`
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #29450:
URL: https://github.com/apache/airflow/pull/29450#issuecomment-1447284299
You are totally right, I wasn't aware that `export-archived` was recently added, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org