You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/01 20:45:20 UTC
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Hello Dinesh Bhat, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5310
to review the following change.
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
tool: Replace Kudu replica with tablet replica in help text
The help text is clearer when we use the term "tablet replica" instead
of "Kudu replica" or just standalone "replica", especially for new
users.
This does not change the names of the modes or actions.
Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
3 files changed, 28 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/5310/1
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5310/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
Line 316: const vector<string> kLocalReplicaModeRegexes = {
Nit: rename to kLocalReplicaCmeta (since it's the cmeta submode of the local replica mode).
http://gerrit.cloudera.org:8080/#/c/5310/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 699: .Description("Print all replica peer UUIDs found in a "
Not "tablet replica peer UUIDs" here?
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5310/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
Line 316: const vector<string> kLocalReplicaModeRegexes = {
> Nit: rename to kLocalReplicaCmeta (since it's the cmeta submode of the loca
Done
http://gerrit.cloudera.org:8080/#/c/5310/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 699: .Description("Print all replica peer UUIDs found in a "
> Not "tablet replica peer UUIDs" here?
Done, I was a little iffy on whether it was redundant with this one but I think it's fine with it.
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
tool: Replace Kudu replica with tablet replica in help text
The help text is clearer when we use the term "tablet replica" instead
of "Kudu replica" or just standalone "replica", especially for new
users.
This does not change the names of the modes or actions.
Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Reviewed-on: http://gerrit.cloudera.org:8080/5310
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
3 files changed, 28 insertions(+), 29 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: Replace Kudu replica with tablet replica in help text
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5310
to look at the new patch set (#2).
Change subject: tool: Replace Kudu replica with tablet replica in help text
......................................................................
tool: Replace Kudu replica with tablet replica in help text
The help text is clearer when we use the term "tablet replica" instead
of "Kudu replica" or just standalone "replica", especially for new
users.
This does not change the names of the modes or actions.
Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
3 files changed, 28 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/5310/2
--
To view, visit http://gerrit.cloudera.org:8080/5310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec236fb145cd4b9c7a5027898f9beb9262f5893a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>