You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Carlos Sanchez (JIRA)" <ji...@codehaus.org> on 2005/10/23 05:58:11 UTC
[jira] Created: (MNG-1286) Check exclusions against relocated artifacts
Check exclusions against relocated artifacts
--------------------------------------------
Key: MNG-1286
URL: http://jira.codehaus.org/browse/MNG-1286
Project: Maven 2
Type: Improvement
Versions: 2.0
Reporter: Carlos Sanchez
Fix For: 2.0.1
When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
<dependency>
<artifactId>commons-dbcp</artifactId>
<groupId>commons-dbcp</groupId>
<version>1.2</version>
<exclusions>
<!-- option a -->
<exclusion>
<artifactId>jdbc</artifactId>
<groupId>jdbc</groupId>
</exclusion>
<!-- option b -->
<exclusion>
<artifactId>jdbc-stdext</artifactId>
<groupId>javax.sql</groupId>
</exclusion>
</exclusions>
</dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=comments#action_49780 ]
Brett Porter commented on MNG-1286:
-----------------------------------
I've changed return; to continue; as I think it should continue to the other children.
Is this correct?
In future, could you please provide a test case that proves that it is fixed (either a unit test, or an integration test)
Thanks!
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=all ]
Brett Porter closed MNG-1286:
-----------------------------
Assign To: Lester Ecarma (was: Edwin Punzalan)
Resolution: Fixed
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Lester Ecarma
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Lester Ecarma (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=comments#action_49797 ]
Lester Ecarma commented on MNG-1286:
------------------------------------
Yes, you're right about using continue instead.
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Lester Ecarma
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Lester Ecarma (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=comments#action_49772 ]
Lester Ecarma commented on MNG-1286:
------------------------------------
Yes, both need to be applied to solve the issue.
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=all ]
Edwin Punzalan updated MNG-1286:
--------------------------------
Attachment: MNG-1287-maven-project.patch
Added the filter object to be passed to MavenMetadataSource.retrieve() so it can be used when relocation has been resolved.
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=all ]
Edwin Punzalan updated MNG-1286:
--------------------------------
Attachment: MNG-1287-maven-project.patch
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Lester Ecarma (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=all ]
Lester Ecarma updated MNG-1286:
-------------------------------
Attachment: MNG-1286-maven-artifact_b.patch
MNG-1286-maven-project_b.patch
Please see attached patches (xxx_b.patch) for a possible solution to this issue.
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=all ]
Edwin Punzalan updated MNG-1286:
--------------------------------
Attachment: MNG-1287-maven-project.patch
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1286) Check exclusions against relocated artifacts
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1286?page=comments#action_49733 ]
Brett Porter commented on MNG-1286:
-----------------------------------
Do these 2 patches relate to each other?
> Check exclusions against relocated artifacts
> --------------------------------------------
>
> Key: MNG-1286
> URL: http://jira.codehaus.org/browse/MNG-1286
> Project: Maven 2
> Type: Improvement
> Versions: 2.0
> Reporter: Carlos Sanchez
> Assignee: Edwin Punzalan
> Fix For: 2.0.1
> Attachments: MNG-1286-maven-artifact_b.patch, MNG-1286-maven-project_b.patch, MNG-1287-maven-project.patch
>
>
> When using an artifact that was relocated you need to exclude the one used directly, it doesn't work if you use the final relocated artifact. This is confusing when you get an artifact in your war but you need to exclude other.
> eg. if you don't use exclusions you get jdbc-stdext in the war. Using option b doesn't work, currently you need to use option a.
> <dependency>
> <artifactId>commons-dbcp</artifactId>
> <groupId>commons-dbcp</groupId>
> <version>1.2</version>
> <exclusions>
> <!-- option a -->
> <exclusion>
> <artifactId>jdbc</artifactId>
> <groupId>jdbc</groupId>
> </exclusion>
> <!-- option b -->
> <exclusion>
> <artifactId>jdbc-stdext</artifactId>
> <groupId>javax.sql</groupId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org