You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "katherine-hough (via GitHub)" <gi...@apache.org> on 2023/06/17 13:51:00 UTC
[GitHub] [commons-bcel] katherine-hough opened a new pull request, #229: [BCEL-368] Fixes java.lang.StackOverflowError in Select#toString(boolean)
katherine-hough opened a new pull request, #229:
URL: https://github.com/apache/commons-bcel/pull/229
* Changed TestJira368 to test InstructionList#toString instead of Code#toString so that the test can reveal the defect in Select#toString(boolean) described in issue 368.
* Fixed issue with Select#toString(boolean) throwing a java.lang.StackOverflowError when there is a self-reference in targets. The message "<points to itself>" (choosen to be consistent with BranchInstruction#toString) is used to represent the self-reference.
Fixes: https://issues.apache.org/jira/browse/BCEL-368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #229: [BCEL-368] Fixes java.lang.StackOverflowError in Select#toString(boolean)
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #229:
URL: https://github.com/apache/commons-bcel/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #229: [BCEL-368] Fixes java.lang.StackOverflowError in Select#toString(boolean)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #229:
URL: https://github.com/apache/commons-bcel/pull/229#issuecomment-1595781512
## [Codecov](https://app.codecov.io/gh/apache/commons-bcel/pull/229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#229](https://app.codecov.io/gh/apache/commons-bcel/pull/229?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4284021) into [master](https://app.codecov.io/gh/apache/commons-bcel/commit/72f736642ee5ad2cfe88dd0cb99c04a9bb09531a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (72f7366) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 64.74% 64.73% -0.01%
Complexity 3872 3872
============================================
Files 364 364
Lines 15667 15669 +2
Branches 1943 1944 +1
============================================
Hits 10143 10143
- Misses 4602 4604 +2
Partials 922 922
```
| [Impacted Files](https://app.codecov.io/gh/apache/commons-bcel/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/main/java/org/apache/bcel/generic/Select.java](https://app.codecov.io/gh/apache/commons-bcel/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvZ2VuZXJpYy9TZWxlY3QuamF2YQ==) | `54.94% <0.00%> (-1.24%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org