You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/03 10:25:43 UTC
[GitHub] [airflow] Junnplus opened a new issue #14044: Display description colume of dag in UI DAG list
Junnplus opened a new issue #14044:
URL: https://github.com/apache/airflow/issues/14044
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
**Description**
Display description colume of dag in UI DAG list.
**Use case / motivation**
display description of dag maybe more friendly for user.
**Are you willing to submit a PR?**
yes.
**Related Issues**
<!-- Is there currently another issue associated with this? -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus edited a comment on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus edited a comment on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-773570606
> The layout is already tight/dense, and adding another column would exacerbate this.
Or we can put the description in the DAG column like tags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-776789979
> > I do agree that making it a searchable property would be very valuable. That seems like it would address what is lacking of the existing hover implementation, no?
>
> In other scenarios, we may need to quickly browse the dag list to find what we want.
> Although dag id can be used instead, but description column is more friendly to non-English speaking countries.
A better fix for this would instead be if we allowed more (read any characters apart from whitespace!) in DAG and task_ids, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-773010459
> I do agree that making it a searchable property would be very valuable. That seems like it would address what is lacking of the existing hover implementation, no?
In other scenarios, we may need to quickly browse the dag list to find what we want.
Although dag id can be used instead, but description column is more friendly to non-English speaking countries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772416593
So if when have hover over why do we need another column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-773570606
> The layout is already tight/dense, and adding another column would exacerbate this.
Or we can put the description in the DAG column like tags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772430148
I think it would be better to display columns than hover.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-776789979
> > I do agree that making it a searchable property would be very valuable. That seems like it would address what is lacking of the existing hover implementation, no?
>
> In other scenarios, we may need to quickly browse the dag list to find what we want.
> Although dag id can be used instead, but description column is more friendly to non-English speaking countries.
A better fix for this would instead be if we allowed more (read any characters apart from whitespace!) in DAG and task_ids, no?
For instance, we should probably support what ever Python does in terms of identifiers: https://www.python.org/dev/peps/pep-3131/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772405361
You can set DAG description with [doc_md](https://github.com/apache/airflow/blob/0e8c77b93a5ca5ecfdcd1c4bd91f54846fc15d57/airflow/models/dag.py#L261) parameter.
Are you asking to expose the value as column in the DAG list? I don't think that is doable. The description can be really long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal removed a comment on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
eladkal removed a comment on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772422568
yes, as I thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772676056
I'm not super keen on adding a column to this table. The layout is already tight/dense, and adding another column would exacerbate this. We made changes in 2.0 to specifically reduce density (hidden links). As an optional DAG attribute, it would also have potential to consume space even when not utilized.
I _do_ agree that making it a searchable property would be very valuable. That seems like it would address what is lacking of the existing hover implementation, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772422568
yes, as I thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-774637291
ping @ryanahamilton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772412295
> Are you asking to expose the value as column in the DAG list?
Right.
> The description can be really long.
We can truncate part of the content like hover content of `DAG` column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] D0zingcat commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
D0zingcat commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772605426
> So if when have hover over why do we need another column?
> 
If here's a column shows description, it would be easier to search for the dags you want to find(i.e. just Cmd+F to find the description), or if the description could be searched, that would be even better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus edited a comment on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus edited a comment on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-773570606
> The layout is already tight/dense, and adding another column would exacerbate this.
Or we can put the description in the DAG column like tags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-772416593
I'm pretty sure that when you define `doc_md` the content appear when you hover over your DAG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on issue #14044: Display description colume of dag in UI DAG list
Posted by GitBox <gi...@apache.org>.
Junnplus commented on issue #14044:
URL: https://github.com/apache/airflow/issues/14044#issuecomment-773570606
> The layout is already tight/dense, and adding another column would exacerbate this.
Or we can put the description in the DAG column like tags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org