You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/14 05:13:58 UTC
[GitHub] [incubator-nuttx-apps] tanushreebaindur opened a new pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
tanushreebaindur opened a new pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716
## Summary
The original PR is: https://github.com/apache/incubator-nuttx-apps/pull/709
examples/nxflat/nxflat_main.c and examples/thttpd/thttpd_main.c are listed in Apps issue #246 but were not included in the original PR (linked above). This PR contains the change from romdisk_register() to boardctl(BOARDIOC_ROMDISK) for examples/nxflat/nxflat_main.c and examples/thttpd/thttpd_main.c.
## Impact
None
## Testing
Change from romdisk_register() to boardctl() has been tested in the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] tanushreebaindur commented on a change in pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
tanushreebaindur commented on a change in pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716#discussion_r633169701
##########
File path: examples/thttpd/thttpd_main.c
##########
@@ -252,12 +259,18 @@ int main(int argc, FAR char *argv[])
netlib_ifup("eth0");
+#ifdef CONFIG_THTTPD_NXFLAT
Review comment:
I first submitted the changes without the guard CONFIG_THTTPD_NXFLAT. The build broke with the error: unused variable 'desc'. This is the link for the build break: https://github.com/apache/incubator-nuttx-apps/runs/2581333837?check_suite_focus=true
Also, originally in the code there is a check to see if CONFIG_FS_ROMFS is enabled (line 91) if CONFIG_THTTPD_NXFLAT is defined (line 86). For this reason I added the guard CONFIG_THTTPD_NXFLAT before registering romdisk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716#discussion_r633122626
##########
File path: examples/thttpd/thttpd_main.c
##########
@@ -252,12 +259,18 @@ int main(int argc, FAR char *argv[])
netlib_ifup("eth0");
+#ifdef CONFIG_THTTPD_NXFLAT
Review comment:
why do we need guard romfs_img registery by CONFIG_THTTPD_NXFLAT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716#discussion_r633122626
##########
File path: examples/thttpd/thttpd_main.c
##########
@@ -252,12 +259,18 @@ int main(int argc, FAR char *argv[])
netlib_ifup("eth0");
+#ifdef CONFIG_THTTPD_NXFLAT
Review comment:
why do we need guard romfs_img registery by CONFIG_THTTPD_NXFLAT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] tanushreebaindur commented on a change in pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
tanushreebaindur commented on a change in pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716#discussion_r633169701
##########
File path: examples/thttpd/thttpd_main.c
##########
@@ -252,12 +259,18 @@ int main(int argc, FAR char *argv[])
netlib_ifup("eth0");
+#ifdef CONFIG_THTTPD_NXFLAT
Review comment:
I first submitted the changes without the guard CONFIG_THTTPD_NXFLAT. The build broke with the error: unused variable 'desc'. This is the link for the build break: https://github.com/apache/incubator-nuttx-apps/runs/2581333837?check_suite_focus=true
Also, originally in the code there is a check to see if CONFIG_FS_ROMFS is enabled (line 91) if CONFIG_THTTPD_NXFLAT is defined (line 86). For this reason I added the guard CONFIG_THTTPD_NXFLAT before registering romdisk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org