You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/24 02:48:17 UTC
[GitHub] [incubator-mxnet] anandj91 commented on a change in pull request
#15124: [MXNET-1294] Priority-based parameter propagation for improved data
parallel training throughput
anandj91 commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r370454224
##########
File path: include/mxnet/c_api.h
##########
@@ -2714,6 +2714,48 @@ MXNET_DLL int MXKVStorePullRowSparseEx(KVStoreHandle handle,
const NDArrayHandle* row_ids,
int priority);
+/*!
+ * \brief broadcast a list of (key, value) pairs from the kvstore
+ * \param handle handle to the kvstore
+ * \param vnum the number of key-value pairs corresponding to vkeys
+ * \param vkeys the list of keys for the values to be pushed
+ * \param onum the number of key-value pairs corresponding to okeys
+ * \param okeys the list of keys for the values to be pulled
+ * \param vals the list of values
+ * \param outs the list of outputs
+ * \param priority the priority of the action
+ * \return 0 when success, -1 when failure happens
+ */
+MXNET_DLL int MXKVStoreBroadcast(KVStoreHandle handle,
+ mx_uint vnum,
+ const int* vkeys,
+ mx_uint onum,
+ const int* okeys,
+ NDArrayHandle* vals,
+ NDArrayHandle* outs,
+ int priority);
+/*!
+ * \brief broadcast a list of (key, value) pairs from the kvstore,
+ * where each key is a string
+ * \param handle handle to the kvstore
+ * \param vnum the number of key-value pairs corresponding to vkeys
+ * \param vkeys the list of keys for the values to be pushed
+ * \param onum the number of key-value pairs corresponding to okeys
+ * \param okeys the list of keys for the values to be pulled
+ * \param vals the list of values
+ * \param outs the list of outputs
+ * \param priority the priority of the action
+ * \return 0 when success, -1 when failure happens
+ */
+MXNET_DLL int MXKVStoreBroadcastEx(KVStoreHandle handle,
+ mx_uint vnum,
+ const char** vkeys,
+ mx_uint onum,
+ const char** okeys,
Review comment:
I was keeping the C++ Broadcast api similar to the PushPull api. But I guess it is redundant to have separate keys even for pushpull. So I have removed from both APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services