You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/13 04:21:58 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #558:
[SCB-1301]Support cluster mode for Syncer
codecov-io commented on issue #558: [SCB-1301]Support cluster mode for Syncer
URL: https://github.com/apache/servicecomb-service-center/pull/558#issuecomment-501542984
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=h1) Report
> Merging [#558](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/605d0da3c68a2158b475ba897cf50eacbef34edb?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #558 +/- ##
=========================================
+ Coverage 58.39% 58.4% +0.01%
=========================================
Files 201 201
Lines 15315 15325 +10
=========================================
+ Hits 8943 8951 +8
- Misses 5746 5747 +1
- Partials 626 627 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/558/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `39.79% <0%> (ø)` | :arrow_up: |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/558/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `84.84% <100%> (-0.34%)` | :arrow_down: |
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/558/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `55.88% <66.66%> (+2.54%)` | :arrow_up: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/558/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/558/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=footer). Last update [605d0da...1ef7810](https://codecov.io/gh/apache/servicecomb-service-center/pull/558?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services