You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Ramjee194 (via GitHub)" <gi...@apache.org> on 2025/02/11 14:13:45 UTC
[PR] Little changes "cache control" [datafusion]
Ramjee194 opened a new pull request, #14611:
URL: https://github.com/apache/datafusion/pull/14611
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Little changes "cache control" [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2755780836
Given it is not clear what problem is solving and it has been dormant for a while, I am going to close it.
Please reopen when we can better articulate why this change is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Little changes "cache control" [datafusion]
Posted by "Ramjee194 (via GitHub)" <gi...@apache.org>.
Ramjee194 commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2654294377
#14611 A cache control header is missing or empty .
A cache control header is mising or empty
meta[name=theme-color]' is not supported by Firefox.
Button type attribute has not been set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Little changes "cache control" [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2656230770
Sorry for the back and forth @Ramjee194
From my perspective the issue is that I don't understand the implications of this change
The ticket and this PR baiscally say "the problem is that the cache control header isn't present"
However, it does not explain *WHY* the lack of a cache control header is a problem. Again I am sorry if this is obvious to you, but it is not obvious to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Little changes "cache control" [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #14611: Little changes "cache control"
URL: https://github.com/apache/datafusion/pull/14611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Little changes "cache control" [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2654889040
> #14611 A cache control header is missing or empty . A cache control header is mising or empty meta[name=theme-color]' is not supported by Firefox. Button type attribute has not been set.
Please be specific about what problem is being caused by not having a cache control header. For example, does it mean updates take too long / short to propagate to you via CDN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org